You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Chris Lombardi (JIRA)" <ji...@apache.org> on 2007/06/28 17:33:26 UTC
[jira] Created: (OFBIZ-1109) Ability to add items with modifiers
Ability to add items with modifiers
-----------------------------------
Key: OFBIZ-1109
URL: https://issues.apache.org/jira/browse/OFBIZ-1109
Project: OFBiz
Issue Type: New Feature
Components: pos
Affects Versions: SVN trunk
Reporter: Chris Lombardi
I would like to add the ability to add and configure "aggregated" items via the POS system.
A few scenarios should be supported.
1. The item has a default configuration and can be added without configuration.
2. The item requires configuration and a screen to configure the item should present upon adding the item.
3. A configurable item should allow editing after both earlier scenarios.
I have a prototype mostly working, but I'd like to determine the following:
1. Is anyone else interested in this functionality?
2. What does everyone think is the best way to accomplish this?
Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552465 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
I think the core is solid enough for a commit. I'll open up new issues for the receipt, cancel button, etc. Thanks.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548778 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
Could you send me the output of "svn diff specialpurpose/pos/src/org/ofbiz/pos/device/impl/Receipt.java"?
Also, have you run a "make clean" lately? I checked the patch, and it looks like all the code is included. I also used the default custreceipt.txt and saw the configuration detail.
Normal:DESC PRICE QTY
Normal:==============================================
Normal:PC001 T 805.00 1
Normal:Configurable PC
Normal: RAM 256 MB
Normal: HD 2 GB
Normal: HD 4 GB
Normal:
Normal: SALES TAX: 0.00
Normal: TOTAL: 805.00
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552310 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
I originally had a "cancel" button, but I ended up removing it. It makes sense from a general purpose program standpoint, but I wasn't sure a "cancel" button made sense in the context of a POS.
What is the expected action of a "cancel"? Would it be to void the item? There is already a "reset" to cancel the configuration changes and reset to the default configuration. You can also hit "ok" and then hit the "void item" button. I didn't want to introduce a way to inadvertently void a bunch of items, etc.
Let me know what you think.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548859 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
OK, I had a closer look. Not sure why (did not search further) but just before printing the receipt on line 386 the productId needs to be trimmed.
if(trans.isAggregatedItem(((String)expandMap.get("productId")).trim())){
At least , it works like that, but it should certainly be better to search why it has trailing blanks only at this stage
Also we see the prices of components in journal but not on receipt. Is that intended ?
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549089 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
I did some research, and I couldn't find a way to get a valid base price that made intuitive sense. So then I went to the e-commerce store to see how it was implemented there.
Configurable PC
PC001 Your Price: $50.00
Hey, 50$ for a PC, I want one! So I click on the item.
Configurable PC
PC001
Product Aggregated Price: $385.00
What?
So, whatever is being called for the price of a "PC001" should probably report the price of the default configuration, not the price of the "unconfigured" product that you can't buy.
My implementation was an inadvertent hack to get around a defect in the pricing of aggregate items.
I'll open another issue for this.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548779 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
Also, are you seeing any relevant errors thrown in the log?
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512466 ]
Bilgin Ibryam commented on OFBIZ-1109:
--------------------------------------
Hi Chris,
I'd like to know how is your progress on this issue?
Are you planning to put a patch, because I also like to see this functionality in POS.
I donot know whats the best way to accomplish it but i can help you in reviewing and testing it.
- Bilgin Ibryam
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547481 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
Did you check the receipt for configuration information? I just checked the patch and it's in there. What printer are you using?
I'll update the code comments, etc.
Did you see anything that wasn't localized aside from the window name? I take the product names, etc, directly from the database.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1109.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547430 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
The dialog boxes shrinked issue is not specifically related to the config item one, the other has the same pb.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547822 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
By default (any changes) I get this :
2007-12-03 13:36:40,953 (Thread-251) [ NullPosPrinter.java:484:INFO ] Normal:
Normal:←|cA←|4C←|bCCompany XYZ
Normal:←|cA←|bC7 E. 8th St. #308
Normal:←|cA←|bCNew York, NY 10003
Normal:←|cA←|bC212.655.3052
Normal:
Normal:←|cASale: RSCO10050 Tx: 10160 Dr: 1 Clerk: 1
Normal:←|cAMon, 3 Dec 2007 13:36:40 CET
Normal:
Normal:DESC PRICE QTY
Normal:==============================================
Normal:PC001 T 385.00 1
Normal:Configurable PC
Normal:
Normal: SALES TAX: 0.00
Normal: TOTAL: 385.00
Normal:
Normal: Cash: 385.00
Normal:
Normal: CHANGE: 0.00
Normal:
Normal:
Barcode:RSCO10050Normal:
Normal:←|cA←|4C←|bCTHANK-YOU
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552354 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Chris, do you think this patch is ready to be commited or should we wait OFBIZ-1495 ?
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552526 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Thanks Chris,
Your patch is in trunk revision: 604993. Some advices, questions and remarks :
Please don't add xpos.properties in your patches. As you may know this file is dynamically modified by the system to allow XUI localisation. About this subject I have added the following lines
### This file contains labels directly translated by XUI framework
### This file contains labels translated by the POS component (ie not by XUI framework)
in respectively XuiUilabels*.properties files and pos*.properties file to make things more obvious.
Should we keep PosTransaction.configureItem commented ?
Please update or remove code comments, for instance the one I already noticed in a comment above
I commented some remaining Debug.logInfo in ConfigureItem feel free to uncomment if you feel they are needed.
Thanks for your great work, I love the color !
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-1109:
--------------------------------------
Assignee: Jacques Le Roux
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552072 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Has I worked on the POS today, I suggest other minor improvements to this patch :
Windows titles are still "Load a sale"
Cancel buttons are missing (we need big buttons because of touch screen)
Please use a new color in the Main POS windows for the "Config PC" button
Thanks
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547428 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Hi Chris,
I just tested on Windows it works well as far as I have gone and the code is well written. Some remarks :
. It's not localised
. I think we should show options on the receipt.
. Please update code comments, for instance
+public class ConfigureItem extends XPage {
+
+ /**
+ * To load a sale from a shopping list. 2 modes : add to or replace the current sale. Also a button to delete a sale (aka shopping list)
+ */
+ //TODO: change caption
+ m_dialog.setCaption(UtilProperties.getMessage("pos", "LoadASale", Locale.getDefault()));
It seems that this patch introduce a quirk : when opening dialog boxes after having opened the the config item dialog boxe all other dialog boxes are shrinked.
Thanks for your work
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547824 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Did not reproduce the shrink issue today. I remember now to have seen this before your patch, maybe it's something on my cluttered machine, just forget it ;o)
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547701 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
Could you post what you see as the null printer output? It's working fine for me under windows and linux, through the null printer and a star printer.
Ahh, the button names. I'll fix that.
Which dialog boxes are shrunken after using the window? After adding a configurable item, I'm able to see error dialogs and the load and save sale dialogs. I have only checked this on windows.
Normal:|cASale: RSCO10000 Tx: 10010 Dr: 1 Clerk: 1
Normal:|cASun, 2 Dec 2007 18:31:53 CST
Normal:
Normal:DESC PRICE QTY
Normal:==============================================
Normal:Configurable PC T 805.00 1
Normal: RAM 256 MB
Normal: HD 2 GB
Normal: HD 4 GB
Normal:
Normal: SALES TAX: 0.00
Normal: TOTAL: 805.00
Normal:
Normal: Cash: 900.00
Normal:
Normal: CHANGE: 95.00
Normal:
Normal:
Barcode:RSCO10000Normal:
Normal:|cA|4C|bCTHANK-YOU
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520842 ]
Bilgin Ibryam commented on OFBIZ-1109:
--------------------------------------
Chris,
If you are busy I can help you in finishing your patch, because i got some free time these days.
I need this feature for selling configurable products (like PC001) through POS for a restaurant.
I hope to have some answer from you soon.
Thanks
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508921 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Chris,
I have no direct interest in this but it's surely interesting to have in the POS.
You may have a look to how the load and save order command are done. It should show you the way to build your own screens (they use a pragmatic approach using XUI but also Swing when needed)
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1109:
----------------------------------
Attachment: 21Nov2007.patch
Beta patch for configurable items in the POS. 80-90% of the functionality is there including configurations showing on journal and receipts, forced item configuration, item configuration modification, and presentation of an dynamic item configuration screen.
If anyone would like to review, test or has an xml file with some configurable test items it would be much appreciated.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548915 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
I couldn't get a base price for the "PC001" from ShoppingCartItem that made sense in the context of showing the configuration item prices. I may be overlooking something simple, I'll take another look tomorrow. Note, the prices of the components show in the journal, but the price of the components are included in the aggregated item line. I think that layout could be somewhat confusing to a customer.
What do you think?
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512811 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
POS has made some decent sized changes recently. I'd like to review the
changes before doing my patch to the trunk version.
If you have a use case in mind, I'd be glad to hear it.
I'm hoping to make some progress this week, so stay tuned.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547690 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
I only looked at the null printer in log and there was no options shown.
At least new button names are not localised also, this is very minor (aka trivial ;o)
The problems is rather the shrinked dialog boxes (on Windows at least, did no test in Linux yet)
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549773 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Did you open the new issue ? I will try to look at this issue this week...
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549775 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Actually the only weird thing is the price of the unconfigured product and I agree that we should better show the price of the default configuration. I never occured to me that there was a problem here has I saw the $ 50 as the price without any options. But as it's something you can't reasonnably buy (like a car without tyres or something) showing the default configuration price should be good. Mmmm... I remember now that you have opened an issue to allow a default configuration, I understand why now :o)
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552347 ]
Jacques Le Roux commented on OFBIZ-1109:
----------------------------------------
Chris,
Just as a side note for patches name. For a commiter who have more than one patch testing at a time, it's easier to have a patch name saying something to him. For instance config-pc-pos.patch would be easier here. Don't worry about versions, Jira is able to take the same name and will grey the previous versions.
For the cancel button, I used one in load and save sale. I think that now everybody is used to the cancel concept on a PC.
Maybe in the context of config we could use a different name (Main screen, back, ... ?).
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549799 ]
Chris Lombardi commented on OFBIZ-1109:
---------------------------------------
Yes, it's ofbiz-1495. I was planning on taking care of it, I just like to give everyone a few days for comments before I start. I'll put you down as a vote for the fix as proposed.
Yeah, having the default configuration, IMHO, is nice. That combined with the default base price is going to go a long way towards better clarity with this patch. I'll have to go through this patch again in light of ofbiz-1393 and ofbiz-1495.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1109) Ability to add items with modifiers
Posted by "Chris Lombardi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Lombardi updated OFBIZ-1109:
----------------------------------
Attachment: 16Dec2007.patch
Window title changed from "Load a sale"
New color used for "Config PC". I tried to keep it the same shade as the other colors.
> Ability to add items with modifiers
> -----------------------------------
>
> Key: OFBIZ-1109
> URL: https://issues.apache.org/jira/browse/OFBIZ-1109
> Project: OFBiz
> Issue Type: New Feature
> Components: pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Attachments: 16Dec2007.patch, 21Nov2007.patch
>
>
> I would like to add the ability to add and configure "aggregated" items via the POS system.
> A few scenarios should be supported.
> 1. The item has a default configuration and can be added without configuration.
> 2. The item requires configuration and a screen to configure the item should present upon adding the item.
> 3. A configurable item should allow editing after both earlier scenarios.
> I have a prototype mostly working, but I'd like to determine the following:
> 1. Is anyone else interested in this functionality?
> 2. What does everyone think is the best way to accomplish this?
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.