You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/25 18:07:58 UTC
Review Request 67725: Added a principal to a disk resource's `source`
field.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67725/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Repository: mesos
Description
-------
In this patch we store the principal given by `CreateVolume` or
`CreateDisk` operations inside the resources created by the operation.
This allows us to authorize `DestroyVolume` or `DestroyDisk`
operations against the principal which triggered the resource's
creation at some later point.
Diffs
-----
include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3
include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1
src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67725/diff/1/
Testing
-------
`sudo make check`
Thanks,
Benjamin Bannier
Re: Review Request 67725: Added a principal to a disk resource's
`source` field.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67725/#review205306
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67723', '67724', '67725']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67725
Relevant logs:
- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67725/logs/stout-tests-cmake-stdout.log):
```
"D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (10) ->
(CustomBuild target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (3) ->
"D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (9) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (6) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (14) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
1 Warning(s)
5 Error(s)
Time Elapsed 00:03:15.94
```
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67725/logs/libprocess-tests-cmake-stdout.log):
```
(CustomBuild target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (10) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (5) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\examples\example.vcxproj" (default target) (9) ->
"D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (20) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\examples\example.vcxproj" (default target) (9) ->
"D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (18) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
113 Warning(s)
5 Error(s)
Time Elapsed 00:03:29.14
```
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67725/logs/mesos-tests-cmake-stdout.log):
```
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (19) ->
"D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj" (default target) (29) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (7) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (19) ->
"D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj" (default target) (30) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (19) ->
"D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (27) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
1 Warning(s)
7 Error(s)
Time Elapsed 00:00:18.71
```
- Mesos Reviewbot Windows
On June 25, 2018, 6:07 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67725/
> -----------------------------------------------------------
>
> (Updated June 25, 2018, 6:07 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In this patch we store the principal given by `CreateVolume` or
> `CreateDisk` operations inside the resources created by the operation.
>
> This allows us to authorize `DestroyVolume` or `DestroyDisk`
> operations against the principal which triggered the resource's
> creation at some later point.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3
> include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1
> src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67725/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67725: Added a principal to a disk resource's
`source` field.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67725/#review205335
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67723, 67724, 67725]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 25, 2018, 11:07 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67725/
> -----------------------------------------------------------
>
> (Updated June 25, 2018, 11:07 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In this patch we store the principal given by `CreateVolume` or
> `CreateDisk` operations inside the resources created by the operation.
>
> This allows us to authorize `DestroyVolume` or `DestroyDisk`
> operations against the principal which triggered the resource's
> creation at some later point.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3
> include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1
> src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67725/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>