You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/10/15 21:57:39 UTC
[PR] Add opt-in native Parquet decoding and column-oriented ingestion [pinot]
xiangfu0 opened a new pull request, #19896:
URL: https://github.com/apache/pinot/pull/19896
Adds opt-in native decoding and column-oriented generation, exact deferred RAW statistics, and bounded canonical MAP-to-JSON reuse, with fallback for unsupported inputs.
**Usage:** enable `useParquetNativeDirectReader` and `useColumnMajorSegmentBuilder` with the native reader; the [Parquet README](https://github.com/xiangfu0/pinot/blob/9f170eabba0c94cd15cbf734be199a04db4f1014/pinot-plugins/pinot-input-format/pinot-parquet/README.md) provides complete batch YAML and statistics settings.
**Validation:** 58 focused tests and style/license checks passed, covering row/column equivalence, statistics, collections, and fallbacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add opt-in native Parquet decoding and column-oriented ingestion [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 closed pull request #19896: Add opt-in native Parquet decoding and column-oriented ingestion
URL: https://github.com/apache/pinot/pull/19896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add opt-in native Parquet decoding and column-oriented ingestion [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #19896:
URL: https://github.com/apache/pinot/pull/19896#discussion_r4288767636
##########
pinot-plugins/pinot-input-format/pinot-parquet/src/main/java/org/apache/pinot/plugin/inputformat/parquet/ParquetRecordReaderConfig.java:
##########
@@ -58,4 +64,19 @@ public boolean isExtractRawTimeValues() {
public void setExtractRawTimeValues(boolean extractRawTimeValues) {
_extractRawTimeValues = extractRawTimeValues;
}
+
+ public boolean useParquetNativeDirectReader() {
+ return _useParquetNativeDirectReader;
+ }
+
+ public void setUseParquetNativeDirectReader(boolean useParquetNativeDirectReader) {
Review Comment:
Minor style: there's no blank line between `setUseParquetNativeDirectReader(...)` and this `useColumnMajorSegmentBuilder()` getter. Every other method here is separated by one. Worth adding a blank line so the linter stays happy and it reads consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add opt-in native Parquet decoding and column-oriented ingestion [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19896:
URL: https://github.com/apache/pinot/pull/19896#issuecomment-6204089270
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19896?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 100.00%. Comparing base ([`c15cead`](https://app.codecov.io/gh/apache/pinot/commit/c15ceadb2d1e56712686e8124178f7831cb83ac4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9f170ea`](https://app.codecov.io/gh/apache/pinot/commit/9f170eabba0c94cd15cbf734be199a04db4f1014?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19896 +/- ##
==============================================
+ Coverage 69.26% 100.00% +30.73%
+ Complexity 1491 6 -1485
==============================================
Files 3543 3 -3540
Lines 233237 6 -233231
Branches 37277 0 -37277
==============================================
- Hits 161560 6 -161554
+ Misses 59184 0 -59184
+ Partials 12493 0 -12493
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+30.73%)` | :arrow_up: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+30.73%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19896/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19896?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add opt-in native Parquet decoding and column-oriented ingestion [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #19896:
URL: https://github.com/apache/pinot/pull/19896#discussion_r4289314996
##########
pinot-plugins/pinot-input-format/pinot-parquet/src/main/java/org/apache/pinot/plugin/inputformat/parquet/ParquetRecordReaderConfig.java:
##########
@@ -58,4 +64,19 @@ public boolean isExtractRawTimeValues() {
public void setExtractRawTimeValues(boolean extractRawTimeValues) {
_extractRawTimeValues = extractRawTimeValues;
}
+
+ public boolean useParquetNativeDirectReader() {
+ return _useParquetNativeDirectReader;
+ }
+
+ public void setUseParquetNativeDirectReader(boolean useParquetNativeDirectReader) {
Review Comment:
Added the missing blank line between the configuration setter and getter. The affected Parquet module formatting, checkstyle, and license checks pass.
Follow-up: [6b5335761e](https://github.com/apache/pinot/commit/6b5335761e430fac16f4e0cff09aab3eabc83917).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org