You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "yunchipang (via GitHub)" <gi...@apache.org> on 2026/04/30 22:09:10 UTC
[PR] MINOR: Migrate controllerSocketTimeoutMs from KafkaConfig to AbstractKafkaConfig [kafka]
yunchipang opened a new pull request, #22188:
URL: https://github.com/apache/kafka/pull/22188
- Add `controllerSocketTimeoutMs()` to `AbstractKafkaConfig` so that code referencing the base config type can access it without casting to `KafkaConfig`.
- Update `NodeToControllerChannelManagerImpl` to use the new method, and remove the now-redundant `val` from `KafkaConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Migrate controllerSocketTimeoutMs from KafkaConfig to AbstractKafkaConfig [kafka]
Posted by "yunchipang (via GitHub)" <gi...@apache.org>.
yunchipang commented on code in PR #22188:
URL: https://github.com/apache/kafka/pull/22188#discussion_r3185160974
##########
server/src/test/java/org/apache/kafka/server/NodeToControllerRequestThreadTest.java:
##########
@@ -98,7 +92,7 @@ void testRetryTimeoutWhileControllerNotAvailable() {
long retryTimeoutMs = 30000;
NodeToControllerRequestThread testRequestThread = new NodeToControllerRequestThread(
Review Comment:
extracted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Migrate controllerSocketTimeoutMs from KafkaConfig to AbstractKafkaConfig [kafka]
Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani commented on code in PR #22188:
URL: https://github.com/apache/kafka/pull/22188#discussion_r3177680673
##########
server/src/test/java/org/apache/kafka/server/NodeToControllerRequestThreadTest.java:
##########
@@ -98,7 +92,7 @@ void testRetryTimeoutWhileControllerNotAvailable() {
long retryTimeoutMs = 30000;
NodeToControllerRequestThread testRequestThread = new NodeToControllerRequestThread(
Review Comment:
Just realized this object testRequestThread creation steps are repeated multiple times. Refactoring this to a util method is better ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Migrate controllerSocketTimeoutMs from KafkaConfig to AbstractKafkaConfig [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #22188:
URL: https://github.com/apache/kafka/pull/22188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Migrate controllerSocketTimeoutMs from KafkaConfig to AbstractKafkaConfig [kafka]
Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani commented on PR #22188:
URL: https://github.com/apache/kafka/pull/22188#issuecomment-4358475465
Would it be better to make another related change [https://github.com/apache/kafka/blob/be36babf5567d34de5ec8aaf67de16c5fbc8932d/serv[…]java/org/apache/kafka/server/NodeToControllerRequestThread.java](https://github.com/apache/kafka/blob/be36babf5567d34de5ec8aaf67de16c5fbc8932d/server/src/main/java/org/apache/kafka/server/NodeToControllerRequestThread.java#L74) in the same PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org