[GitHub] [hive] amansinha100 commented on a diff in pull request #3674: HIVE-26633: Make Thrift MaxMessageSize configurable

[GitBox <gi...@apache.org>]

amansinha100 commented on code in PR #3674:
URL: https://github.com/apache/hive/pull/3674#discussion_r997487069


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2913,7 +2913,10 @@ public static enum ConfVars {
     HIVE_STATS_MAX_NUM_STATS("hive.stats.max.num.stats", (long) 10000,
         "When the number of stats to be updated is huge, this value is used to control the number of \n" +
         " stats to be sent to HMS for update."),
-
+    HIVE_THRIFT_MAX_MESSAGE_SIZE("hive.thrift.max.message.size", "1gb",

Review Comment:
   I see.. I agree that hive.server2.thrift.max.message.size is getting used for a different purpose (for the stringLengthLimit and containerLengthLimit) and it would not be appropriate to overload that for our use (I didn't realize earlier that this setting has been around since 8 years or so). 
   Regarding the naming for the new setting, currently I don't have a better suggestion.  I can foresee fair amount of confusion about these 2 config options.  Let me give it some more thought. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org