You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:07:30 UTC

[GitHub] [hudi] wangxianghu commented on pull request #2222: [HUDI-1364] Add HoodieStandaloneEngineContext to hudi-standalone-client

wangxianghu commented on pull request #2222:
URL: https://github.com/apache/hudi/pull/2222#issuecomment-720422603


   > The code LGTM, @wangxianghu agree?
   > Naming is always hard :) Standalone is a bit confusing for me, compute engine has standalone mode too, like https://spark.apache.org/docs/latest/spark-standalone.html.
   > I slightly prefer hudi-java-client. From this name, I can tell this client is running a java app.
   > Is this module only being used for local testing, or there will be something else to use this?
   
   @garyli1019 yes, the code LGTM.
   I prefer `hudi-java-client` too, standalone is a bit big for a java client.  
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org