You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/18 08:29:32 UTC

[GitHub] [cloudstack-go] davidjumani commented on a diff in pull request #26: Fix listVPCs unmarshall error when a VPC has network tiers attached

davidjumani commented on code in PR #26:
URL: https://github.com/apache/cloudstack-go/pull/26#discussion_r851972228


##########
generate/generate.go:
##########
@@ -1849,6 +1849,8 @@ func mapType(aName string, pName string, pType string) string {
 	case "list":
 		if pName == "downloaddetails" || pName == "owner" {
 			return "[]map[string]string"
+		} else if pName == "network" {
+			return "[]Network"

Review Comment:
   ```suggestion
   			return "[]*Network"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org