You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/07/16 14:15:54 UTC

[GitHub] [pulsar] zymap commented on a change in pull request #4738: [WIP][Transaction][buffer] Add basic operation of transaction

zymap commented on a change in pull request #4738: [WIP][Transaction][buffer] Add basic operation of transaction
URL: https://github.com/apache/pulsar/pull/4738#discussion_r303933894
 
 

 ##########
 File path: pulsar-transaction/buffer/src/main/java/org/apache/pulsar/transaction/buffer/TransactionBuffer.java
 ##########
 @@ -99,6 +99,8 @@
                                       long committedAtLedgerId,
                                       long committedAtEntryId);
 
+    CompletableFuture<Void> commitTxn(TxnID txnID, long committedAtLedgerId, long committedAtEntryId, ByteBuf marker);
 
 Review comment:
   So the marker in data ledgers is different from the transaction log?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services