[GitHub] [maven-shade-plugin] mkarg commented on a change in pull request #17: [MSHADE-313] - Keep Services

[GitBox <gi...@apache.org>]

mkarg commented on a change in pull request #17: [MSHADE-313] - Keep Services
URL: https://github.com/apache/maven-shade-plugin/pull/17#discussion_r271471607
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java
 ##########
 @@ -138,13 +140,19 @@ private void removeServices( final MavenProject project, final Clazzpath cp )
                         }
 
                         try ( final BufferedReader bufferedReader =
-                           new BufferedReader( new InputStreamReader( jar.getInputStream( jarEntry ) ) ) )
+                           new BufferedReader( new InputStreamReader( jar.getInputStream( jarEntry ), UTF_8 ) ) )
                         {
                             for ( String className = bufferedReader.readLine(); className != null;
                                 className = bufferedReader.readLine() )
                             {
-                               log.info( className + " was not removed because it is a service" );
-                               removeClass( cp , className );
+                                className = className.split( "#", 2 )[0].trim();
 
 Review comment:
   The description of `ServiceClass` says that a line in a service descriptor file may optionally be appended by a hash-separated comment. That line cuts away such optional comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services