You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:07:29 UTC
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2201: gs2200m: Add function to get IWNWID / IWFREQ / IWSENS information
masayuki2009 commented on a change in pull request #2201:
URL: https://github.com/apache/incubator-nuttx/pull/2201#discussion_r515837637
##########
File path: include/nuttx/wireless/gs2200m.h
##########
@@ -48,6 +48,7 @@
#include <nuttx/config.h>
#include <nuttx/irq.h>
#include <nuttx/wireless/ioctl.h>
+#include <nuttx/wireless/wireless.h>
Review comment:
Do we need to include wireless.h in gs2200m.h?
I think it should be included in gs2200m.c instead, because definitions or types in wireless.h are not used in gs2200m.h
##########
File path: include/nuttx/wireless/gs2200m.h
##########
@@ -48,6 +48,7 @@
#include <nuttx/config.h>
#include <nuttx/irq.h>
#include <nuttx/wireless/ioctl.h>
+#include <nuttx/wireless/wireless.h>
Review comment:
In that case, please include wireless.h in both gs2200m.c and gs2200m_main.c and remove the above line in gs2200m.h
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org