Re: [PR] IGNITE-28292 Properly unwrap authentication exception [ignite-3]

["ptupitsyn (via GitHub)" <gi...@apache.org>]

ptupitsyn commented on code in PR #7817:
URL: https://github.com/apache/ignite-3/pull/7817#discussion_r2959682238


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -516,6 +517,11 @@ private void handshake(ChannelHandlerContext ctx, ClientMessageUnpacker unpacker
                     .thenCompose(unused -> authenticationManager.authenticateAsync(authReq))
                     .whenCompleteAsync((user, err) -> {
                         if (err != null) {
+                            if (isAuthenticationException(err)) {
+                                LOG.warn("Client authentication failed [connectionId={}, remoteAddress={}, identity={}]: {}",

Review Comment:
   I don't think those logs should have `warn` level, failed authn is "normal operation" for the server. Maybe debug?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org