You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "sigram (via GitHub)" <gi...@apache.org> on 2023/11/20 16:54:31 UTC
[PR] Add support for optional DBQ expansion. [solr-sandbox]
sigram opened a new pull request, #91:
URL: https://github.com/apache/solr-sandbox/pull/91
This PR adds a boolean config option `expandDbq` (defaults to true) that allows to control whether Delete-By-Query should be expanded on the source-side into a series of Delete-By-Ids. There are tradeoffs in either case so it makes sense to expose this as a configurable option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Add support for optional DBQ expansion. [solr-sandbox]
Posted by "sigram (via GitHub)" <gi...@apache.org>.
sigram commented on PR #91:
URL: https://github.com/apache/solr-sandbox/pull/91#issuecomment-1827998881
If there are no objections I'd like to merge this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Add support for optional DBQ expansion. [solr-sandbox]
Posted by "markrmiller (via GitHub)" <gi...@apache.org>.
markrmiller commented on PR #91:
URL: https://github.com/apache/solr-sandbox/pull/91#issuecomment-1828655126
Looks fine to me. We may want to make it an enum or something instead of a boolean though, so we are free to easily add further options. I haven't brought it over yet, but you can actually choose 3 or 4 delete by query options on the wip branch. Don't expand, expand and use deep paging, and expand without deep paging. I can't remember if there was a fourth. We may just end up with the two, but if we do add another, it would be nice not to have to break or transition the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Add support for optional DBQ expansion. [solr-sandbox]
Posted by "sigram (via GitHub)" <gi...@apache.org>.
sigram merged PR #91:
URL: https://github.com/apache/solr-sandbox/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org