You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/01/15 14:20:04 UTC

[GitHub] incubator-brooklyn pull request: BROOKLYN-215: fix NPE when SshMac...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1150

    BROOKLYN-215: fix NPE when SshMachineLocation.port==null

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/BROOKLYN-215

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1150
    
----
commit e07f0ee16a71c932b9b8adfbd1bbf2bb5f7d19c6
Author: Aled Sage <al...@gmail.com>
Date:   2016-01-15T13:18:13Z

    BROOKLYN-215: fix NPE when SshMachineLocation.port==null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: BROOKLYN-215: fix NPE when SshMac...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1150#issuecomment-171970307
  
    Thanks, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: BROOKLYN-215: fix NPE when SshMac...

Posted by bostko <gi...@git.apache.org>.

Github user bostko commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1150#discussion_r49853491
  
    --- Diff: brooklyn-server/core/src/test/java/org/apache/brooklyn/core/mgmt/rebind/RebindSshMachineLocationTest.java ---
    @@ -80,5 +80,23 @@ public void testMachineUsableAfterRebind() throws Exception {
             
             assertEquals(newChildLoc.execScript(Collections.<String,Object>emptyMap(), "mysummary", ImmutableList.of("true")), 0);
         }
    -    
    +
    +    // See https://issues.apache.org/jira/browse/BROOKLYN-215
    +    @Test(groups="Integration")
    +    public void testRebindWhenPortNull() throws Exception {
    +        SshMachineLocation machine = origManagementContext.getLocationManager().createLocation(LocationSpec.create(SshMachineLocation.class)
    +                .configure("address", "localhost")
    +                .configure("port", null));
    --- End diff --
    
    You could use SshTool.PROP_PORT.getName()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: BROOKLYN-215: fix NPE when SshMac...

Posted by bostko <gi...@git.apache.org>.

Github user bostko commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1150#issuecomment-171964305
  
    Looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: BROOKLYN-215: fix NPE when SshMac...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/1150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---