You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/26 19:34:12 UTC
Re: Review Request 71047: Added unsuppressing via `updateFramework()`
to Java example framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71047/
-----------------------------------------------------------
(Updated July 26, 2019, 7:34 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Removed excercising REVIVE.
Summary (updated)
-----------------
Added unsuppressing via `updateFramework()` to Java example framework.
Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849
Repository: mesos
Description (updated)
-------
This patch ensures that the list of suppressed roles is passed through
the `updateFramework()` of Java V0 bindings. Now the framework
subscribes with all roles suppressed and after that issues
UPDATE_FRAMEWORK call to unsuppress offers.
Diffs (updated)
-----
src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
Diff: https://reviews.apache.org/r/71047/diff/4/
Changes: https://reviews.apache.org/r/71047/diff/3-4/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=5 --verbose`
Thanks,
Andrei Sekretenko
Re: Review Request 71047: Added unsuppressing via `updateFramework()`
to Java example framework.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71047/#review216915
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 26, 2019, 7:34 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71047/
> -----------------------------------------------------------
>
> (Updated July 26, 2019, 7:34 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch ensures that the list of suppressed roles is passed through
> the `updateFramework()` of Java V0 bindings. Now the framework
> subscribes with all roles suppressed and after that issues
> UPDATE_FRAMEWORK call to unsuppress offers.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
>
>
> Diff: https://reviews.apache.org/r/71047/diff/4/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=5 --verbose`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 71047: Added unsuppressing via `updateFramework()`
to Java example framework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71047/#review216897
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71047]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 26, 2019, 12:34 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71047/
> -----------------------------------------------------------
>
> (Updated July 26, 2019, 12:34 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch ensures that the list of suppressed roles is passed through
> the `updateFramework()` of Java V0 bindings. Now the framework
> subscribes with all roles suppressed and after that issues
> UPDATE_FRAMEWORK call to unsuppress offers.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a
>
>
> Diff: https://reviews.apache.org/r/71047/diff/4/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=5 --verbose`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>