You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/23 19:48:17 UTC
[GitHub] [tvm] crawlingcub opened a new pull request, #12563: [PyTorch][Fix] Fix for numerically unstable logsigmoid
crawlingcub opened a new pull request, #12563:
URL: https://github.com/apache/tvm/pull/12563
Fix for #12524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #12563: [PyTorch][Fix] Fix for numerically unstable logsigmoid
Posted by GitBox <gi...@apache.org>.
masahi merged PR #12563:
URL: https://github.com/apache/tvm/pull/12563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #12563: [PyTorch][Fix] Fix for numerically unstable logsigmoid
Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #12563:
URL: https://github.com/apache/tvm/pull/12563#discussion_r953303116
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -814,6 +814,14 @@ def test_forward_log_sigmoid():
verify_model(torch.nn.LogSigmoid().eval(), input_data=input_data)
+@tvm.testing.uses_gpu
+def test_forward_log_sigmoid_overflow():
Review Comment:
Please add a new test under https://github.com/apache/tvm/blob/f64a3bda253f4220d66eeb3348f93f486392cb8e/tests/python/frontend/pytorch/test_forward.py#L814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #12563: [PyTorch][Fix] Fix for numerically unstable logsigmoid
Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #12563:
URL: https://github.com/apache/tvm/pull/12563#discussion_r953302670
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -814,6 +814,14 @@ def test_forward_log_sigmoid():
verify_model(torch.nn.LogSigmoid().eval(), input_data=input_data)
+@tvm.testing.uses_gpu
+def test_forward_log_sigmoid_overflow():
+ """test_forward_log_sigmoid"""
+ torch.set_grad_enabled(False)
+ input_data = torch.tensor([-300.0, -100.0).float()
Review Comment:
There is a syntax error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] crawlingcub commented on a diff in pull request #12563: [PyTorch][Fix] Fix for numerically unstable logsigmoid
Posted by GitBox <gi...@apache.org>.
crawlingcub commented on code in PR #12563:
URL: https://github.com/apache/tvm/pull/12563#discussion_r953315817
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -814,6 +814,14 @@ def test_forward_log_sigmoid():
verify_model(torch.nn.LogSigmoid().eval(), input_data=input_data)
+@tvm.testing.uses_gpu
+def test_forward_log_sigmoid_overflow():
+ """test_forward_log_sigmoid"""
+ torch.set_grad_enabled(False)
+ input_data = torch.tensor([-300.0, -100.0).float()
Review Comment:
fixed
##########
tests/python/frontend/pytorch/test_forward.py:
##########
@@ -814,6 +814,14 @@ def test_forward_log_sigmoid():
verify_model(torch.nn.LogSigmoid().eval(), input_data=input_data)
+@tvm.testing.uses_gpu
+def test_forward_log_sigmoid_overflow():
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org