[jira] [Commented] (GEODE-3563) SSL socket handling problems in TCPConduit run

["Bruce Schuchardt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203952#comment-16203952 ] 

Bruce Schuchardt commented on GEODE-3563:
-----------------------------------------

The problem with TCPConduit.run() definitely needs to be addressed.

Since TCPConduit will just reattempt connecting to a member on a handshake timeout I'm curious why you think it would help matters to add a handshake timeout?  Is the next attempt likely to go any faster?

> SSL socket handling problems in TCPConduit run
> ----------------------------------------------
>
>                 Key: GEODE-3563
>                 URL: https://issues.apache.org/jira/browse/GEODE-3563
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Vahram Aharonyan
>            Priority: Critical
>
> Here are two cases that seems to problematic in TCPConduit.run flow:
> 1. TCPConduit.run() has no action performed for the case when SSLException is thrown from sslSocket.startHandshake(), as a result the socket remains open. 
> Catch block from the end of  configureServerSSLSocket() will just report a fatal error(even it seem that this portion is going to be removed in 1.2.1 according to GEODE-3393) and re-throw the exception.
> 2. configureServerSSLSocket call is performed without setting socket timeout before that. This can bring to run thread blocking case if read initiated from the SSL handshake flow will not return. Linking to similar issues observed with other acceptors previously: GEODE-2898, GEODE-3023.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)