You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by mgoulish <gi...@git.apache.org> on 2018/11/01 09:14:56 UTC
[GitHub] qpid-dispatch pull request #413: DISPATCH-1163 : disallow array overrun if l...
GitHub user mgoulish opened a pull request:
https://github.com/apache/qpid-dispatch/pull/413
DISPATCH-1163 : disallow array overrun if links exceed max priority.
A one-word change to disallow array overrun, and a 48-word comment to explain it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-1163
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/413.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #413
----
commit 8d9fa9b61bc6243f43139c31c84f985d307218f1
Author: Michael Goulish <mg...@...>
Date: 2018-11-01T09:11:35Z
DISPATCH-1163 : disallow array overrun if links exceed max priority.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #413: DISPATCH-1163 : disallow array overrun if links ex...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/413
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/413?src=pr&el=h1) Report
> Merging [#413](https://codecov.io/gh/apache/qpid-dispatch/pull/413?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/aacb11ad2bfa02430dfb289667c0d3f8cec58a0e?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/413?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
- Coverage 85.17% 85.16% -0.02%
==========================================
Files 78 78
Lines 17429 17430 +1
==========================================
- Hits 14845 14844 -1
- Misses 2584 2586 +2
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/413?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.27% <100%> (ø)` | :arrow_up: |
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.12% <0%> (-0.72%)` | :arrow_down: |
| [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.27% <0%> (-0.57%)` | :arrow_down: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `89.86% <0%> (-0.3%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.39% <0%> (-0.13%)` | :arrow_down: |
| [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `85.52% <0%> (+0.26%)` | :arrow_up: |
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `93.42% <0%> (+0.28%)` | :arrow_up: |
| [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/413/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `93.54% <0%> (+0.96%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/413?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/413?src=pr&el=footer). Last update [aacb11a...8d9fa9b](https://codecov.io/gh/apache/qpid-dispatch/pull/413?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #413: DISPATCH-1163 : disallow array overrun if l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/413
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org