You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/15 03:01:17 UTC
[GitHub] [kafka] mkandaswamy opened a new pull request #11494: [WIP] MINOR: Improve KafkaStreamsTest: testInitializesAndDestroysMetricsReporters
mkandaswamy opened a new pull request #11494:
URL: https://github.com/apache/kafka/pull/11494
Add additional asserts for KafkaStreamsTest: testInitializesAndDestroysMetricsReporters to help diagnose if it flakily fails in the future.
* MockMetricsReporter gets initialized only once during KafkaStreams construction, so make assert check stricter by ensuring initDiff is one.
* Assert KafkaStreams is not running before, we validate whether MockMetricsMetricsReporter close count got incremented after streams close.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #11494: MINOR: Improve KafkaStreamsTest: testInitializesAndDestroysMetricsReporters
Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #11494:
URL: https://github.com/apache/kafka/pull/11494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #11494: MINOR: Improve KafkaStreamsTest: testInitializesAndDestroysMetricsReporters
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11494:
URL: https://github.com/apache/kafka/pull/11494#issuecomment-970099509
Test failures are known to be flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mkandaswamy commented on pull request #11494: MINOR: Improve KafkaStreamsTest: testInitializesAndDestroysMetricsReporters
Posted by GitBox <gi...@apache.org>.
mkandaswamy commented on pull request #11494:
URL: https://github.com/apache/kafka/pull/11494#issuecomment-969156394
Test failures: org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testSourceTaskNotBlockedOnShutdownWithNonExistentTopic and kafka.admin.LeaderElectionCommandTest.[1] doesn't seem to be related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org