[GitHub] wido commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #3186: Add possibility to set KVM MTU size for NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r260906684
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
 ##########
 @@ -1191,6 +1196,9 @@ public String toString() {
             if (_networkName != null) {
                 netBuilder.append("<target dev='" + _networkName + "'/>\n");
             }
+            if (_mtu > 0 && _mtu <= 9000) {
 
 Review comment:
   I see you silently skip the MTU if it's equal to 9000, but some networks also allow 9216 as that's what the switch allows.
   
   I'm also not seeing why we should allow an MTU of 10 or something. Shouldn't 1280 be the minimum?
   
   And shouldn't the API do this check already?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services