[GitHub] [servicecomb-pack] chanjarster commented on a change in pull request #517: SCB-1386 Introduce sendingSagaEnd attribute to SagaStart and Compensable annotations

[GitBox <gi...@apache.org>]

chanjarster commented on a change in pull request #517: SCB-1386 Introduce sendingSagaEnd attribute to SagaStart and Compensable annotations
URL: https://github.com/apache/servicecomb-pack/pull/517#discussion_r307999416
 
 

 ##########
 File path: omega/omega-transaction/src/main/java/org/apache/servicecomb/pack/omega/transaction/annotations/Compensable.java
 ##########
 @@ -72,4 +72,11 @@
    * @return the timeout value
    */
   int timeout() default 0;
+
+  /**
+   * Sending out SagaEnd event to Alpha once the SagaStart annotated method is finished without any error.
+   * Default value is false, which means Omega never send out the SagaEnd event to Alpha once the annotated method is finished.
+   * value is true, means this method is last compensable method need to be called, Omega will send SagaEnd event to Alpha once the method is finished.
+   */
+  boolean sendingSagaEnd() default false;
 
 Review comment:
   javadoc is related to @SagaStart but this class is @Compensable.
   Besides, that looks weird to have a method named sendingSagaEnd here.
   Would you like to explain the purpose of this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services