You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/05/18 14:39:01 UTC

[GitHub] [yunikorn-k8shim] pbacsko commented on a diff in pull request #277: [YUNIKORN-641]: Add events for placeholder timeout to pod

pbacsko commented on code in PR #277:
URL: https://github.com/apache/yunikorn-k8shim/pull/277#discussion_r875983448


##########
pkg/cache/context.go:
##########
@@ -697,7 +697,17 @@ func (ctx *Context) AddTask(request *interfaces.AddTaskRequest) interfaces.Manag
 					zap.String("appID", app.applicationID),
 					zap.String("taskID", task.taskID),
 					zap.String("taskState", task.GetTaskState()))
-
+				if app.originatingTask == nil {

Review Comment:
   Don't we need lock-protected getter to access this field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org