You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by sy...@apache.org on 2015/04/26 23:32:28 UTC
lucenenet git commit: use CompareOrdinal vs CompareTo
Repository: lucenenet
Updated Branches:
refs/heads/master 38139379b -> b692fc0d8
use CompareOrdinal vs CompareTo
Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/b692fc0d
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/b692fc0d
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/b692fc0d
Branch: refs/heads/master
Commit: b692fc0d8156517b7625a37be7ffa3dce2a1c050
Parents: 3813937
Author: Laimonas Simutis <la...@gmail.com>
Authored: Sun Apr 26 13:30:33 2015 -0400
Committer: Laimonas Simutis <la...@gmail.com>
Committed: Sun Apr 26 13:30:33 2015 -0400
----------------------------------------------------------------------
.../core/Util/TestIndexableBinaryStringTools.cs | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b692fc0d/src/Lucene.Net.Tests/core/Util/TestIndexableBinaryStringTools.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests/core/Util/TestIndexableBinaryStringTools.cs b/src/Lucene.Net.Tests/core/Util/TestIndexableBinaryStringTools.cs
index bb9738d..339e7ad 100644
--- a/src/Lucene.Net.Tests/core/Util/TestIndexableBinaryStringTools.cs
+++ b/src/Lucene.Net.Tests/core/Util/TestIndexableBinaryStringTools.cs
@@ -82,7 +82,9 @@ namespace Lucene.Net.Util
original2[byteNum] = (sbyte)randomInt;
originalString2[byteNum] = (char)randomInt;
}
- int originalComparison = (new string(originalString1, 0, numBytes1)).CompareTo(new string(originalString2, 0, numBytes2));
+ int originalComparison = String.CompareOrdinal(new string(originalString1, 0, numBytes1),
+ new string(originalString2, 0, numBytes2));
+
originalComparison = originalComparison < 0 ? -1 : originalComparison > 0 ? 1 : 0;
int encodedLen1 = IndexableBinaryStringTools.GetEncodedLength(originalArray1, 0, numBytes1);
@@ -99,7 +101,9 @@ namespace Lucene.Net.Util
}
IndexableBinaryStringTools.Encode(original2, 0, numBytes2, encoded2, 0, encodedLen2);
- int encodedComparison = (new string(encoded1, 0, encodedLen1)).CompareTo(new string(encoded2, 0, encodedLen2));
+ int encodedComparison = String.CompareOrdinal(new string(encoded1, 0, encodedLen1),
+ new string(encoded2, 0, encodedLen2));
+
encodedComparison = encodedComparison < 0 ? -1 : encodedComparison > 0 ? 1 : 0;
Assert.AreEqual(originalComparison, encodedComparison, "Test #" + (testNum + 1) + ": Original bytes and encoded chars compare differently:" + " \nbinary 1: " + BinaryDump(originalArray1, numBytes1) + " \nbinary 2: " + BinaryDump(original2, numBytes2) + "\nencoded 1: " + CharArrayDump(encoded1, encodedLen1) + "\nencoded 2: " + CharArrayDump(encoded2, encodedLen2));