You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by aa...@apache.org on 2009/05/05 14:27:32 UTC

svn commit: r771694 - in /cayenne/main/trunk: docs/doc/src/main/resources/RELEASE-NOTES.txt framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/SelectPropertiesPanel.java

Author: aadamchik
Date: Tue May  5 12:27:24 2009
New Revision: 771694

URL: http://svn.apache.org/viewvc?rev=771694&view=rev
Log:
CAY-1219 Modeler - clicking on query "select properties" fields changes project status to "dirty"

patch by Dima Loiko

Modified:
    cayenne/main/trunk/docs/doc/src/main/resources/RELEASE-NOTES.txt
    cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/SelectPropertiesPanel.java

Modified: cayenne/main/trunk/docs/doc/src/main/resources/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/docs/doc/src/main/resources/RELEASE-NOTES.txt?rev=771694&r1=771693&r2=771694&view=diff
==============================================================================
--- cayenne/main/trunk/docs/doc/src/main/resources/RELEASE-NOTES.txt (original)
+++ cayenne/main/trunk/docs/doc/src/main/resources/RELEASE-NOTES.txt Tue May  5 12:27:24 2009
@@ -62,6 +62,7 @@
 CAY-1204 Incorrect relationship syncing in nested CayenneContext's
 CAY-1207 Oracle8 does not like new join syntax
 CAY-1217 Project tree loses focus when traversing a list of entities with the keyboard
+CAY-1219 Modeler - clicking on query "select properties" fields changes project status to "dirty"
 
 ----------------------------------
 Release: 3.0M5

Modified: cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/SelectPropertiesPanel.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/SelectPropertiesPanel.java?rev=771694&r1=771693&r2=771694&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/SelectPropertiesPanel.java (original)
+++ cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/SelectPropertiesPanel.java Tue May  5 12:27:24 2009
@@ -43,9 +43,11 @@
 import org.apache.cayenne.query.Query;
 import org.apache.cayenne.query.QueryCacheStrategy;
 import org.apache.cayenne.reflect.PropertyUtils;
+import org.apache.cayenne.util.Util;
 import org.apache.cayenne.validation.ValidationException;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+import org.apache.velocity.texen.util.PropertiesUtil;
 
 /**
  * A panel that supports editing the properties of a GenericSelectQuery.
@@ -264,6 +266,10 @@
         Query query = getQuery();
         if (query != null) {
             try {
+                Object old = PropertyUtils.getProperty(query, property);
+                if (Util.nullSafeEquals(value, old)) {
+                    return;
+                }
                 PropertyUtils.setProperty(query, property, value);
                 mediator.fireQueryEvent(new QueryEvent(this, query));
             }