You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Ian Cook (Jira)" <ji...@apache.org> on 2021/04/01 20:27:00 UTC
[jira] [Comment Edited] (ARROW-12182) [R] [Dev] new helpers and
suggests for testing
[ https://issues.apache.org/jira/browse/ARROW-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313430#comment-17313430 ]
Ian Cook edited comment on ARROW-12182 at 4/1/21, 8:26 PM:
-----------------------------------------------------------
Regarding glue: dplyr has glue in its Imports, so as long as we're only using glue in tests when dplyr is loaded and we're prefacing glue functions with {{glue::}} I don't think we need to add it to the arrow Suggests.
was (Author: icook):
Regarding glue: dplyr has glue in its Imports, so as long as we're only using glue in tests when dplyr is loaded, I don't think we need to add it to the arrow Suggests.
> [R] [Dev] new helpers and suggests for testing
> ----------------------------------------------
>
> Key: ARROW-12182
> URL: https://issues.apache.org/jira/browse/ARROW-12182
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Developer Tools, R
> Affects Versions: 3.0.0
> Reporter: Mauricio 'Pachá' Vargas Sepúlveda
> Assignee: Mauricio 'Pachá' Vargas Sepúlveda
> Priority: Minor
>
> _Related to https://issues.apache.org/jira/browse/ARROW-11705_
> While working on the related tickets I've found the next blockers:
> 1. Does it make sense to create expect_dplyr_named()? (i.e. to mimic https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L56-L59)
> 2. Does it make sense to create expect_dplyr_identical() (i.e. to mimic https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L61-L69 and https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L83-L91)
> 3. Should we need to add glue to Suggests? (i.e. replicate https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L95-L100)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)