You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by kjduling <gi...@git.apache.org> on 2016/06/07 19:32:32 UTC

[GitHub] incubator-geode pull request #151: GEODE-744: Incorrect use of APP_FETCH_SIZ...

GitHub user kjduling opened a pull request:

    https://github.com/apache/incubator-geode/pull/151

    GEODE-744: Incorrect use of APP_FETCH_SIZE in GFSH

    Changed the test to be case-insensitive.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-744

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #151
    
----
commit c02dd1c1f2d176b5ce6316516278a064d8b2afaa
Author: Kevin J. Duling <kd...@pivotal.io>
Date:   2016-06-07T19:29:19Z

    GEODE-744: Incorrect use of APP_FETCH_SIZE in GFSH

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #151: GEODE-744: Incorrect use of APP_FETCH_SIZ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/151


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #151: GEODE-744: Incorrect use of APP_FETCH_SIZE in GF...

Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:

    https://github.com/apache/incubator-geode/pull/151
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #151: GEODE-744: Incorrect use of APP_FETCH_SIZE in GF...

Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:

    https://github.com/apache/incubator-geode/pull/151
  
    I don't think this would fix the problem. The problem is that the following two queries would return different results. Your change would still make them do that.
    
    query --query=\"select count(*) from /replicatedRegion.keySet\"
    query --query=\"SELECT COUNT(*) FROM /replicatedRegion.keySet\"
    
    I believe what Jens suggests is to convert the query string to lowercase/uppercase first and then checks for "contains" limit or count.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #151: GEODE-744: Incorrect use of APP_FETCH_SIZE in GF...

Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:

    https://github.com/apache/incubator-geode/pull/151
  
    Not sure if this works, the example it gives are those queries
    echo "query --query=\"select count(*) from /replicatedRegion.keySet\"" >> query_region.gfsh
    echo "query --query=\"SELECT COUNT(*) FROM /replicatedRegion.keySet\"" >> query_region.gfsh
    
    would count() be the same as count(*)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---