You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/08/05 20:33:56 UTC

[kudu-CR] heartbeater: slight fixes to backoff behavior 

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3847

to review the following change.

Change subject: heartbeater: slight fixes to backoff behavior
......................................................................

heartbeater: slight fixes to backoff behavior

1. There was an off-by-one error when deciding how many failed heartbeats
   should lead to back off.
2. We only reset the connection to the master when transitioning to back off
   behavior, but I think the original intent was to reset it on every failed
   heartbeat thereafter.

These changes shouldn't have any real impact, but I think they make the back
off behavior more intuitive.

Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747
---
M src/kudu/tserver/heartbeater.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/3847/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] heartbeater: slight fixes to backoff behavior

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: heartbeater: slight fixes to backoff behavior
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2718/

-- 
To view, visit http://gerrit.cloudera.org:8080/3847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] heartbeater: slight fixes to backoff behavior

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: heartbeater: slight fixes to backoff behavior
......................................................................


heartbeater: slight fixes to backoff behavior

1. There was an off-by-one error when deciding how many failed heartbeats
   should lead to back off.
2. We only reset the connection to the master when transitioning to back off
   behavior, but I think the original intent was to reset it on every failed
   heartbeat thereafter.

These changes shouldn't have any real impact, but I think they make the back
off behavior more intuitive.

Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747
Reviewed-on: http://gerrit.cloudera.org:8080/3847
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tserver/heartbeater.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] heartbeater: slight fixes to backoff behavior

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: heartbeater: slight fixes to backoff behavior
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No