You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/26 14:54:53 UTC

[GitHub] [airflow] yuqian90 commented on pull request #12058: Treat AirflowSensorTimeout as immediate failure without retrying

yuqian90 commented on pull request #12058:
URL: https://github.com/apache/airflow/pull/12058#issuecomment-848838743


   > > cc @andrewgodwin Can you take a look at this too please to see if this timeouts have any effect on the Deferrable tasks/sensors
   > 
   > The `timeout` parameter is documented as only for `reschedule` mode Sensors, so Deferrable operators won't use it (since they are never using `reschedule`). Do we want to apply it to all Deferrable Operators as well, or just make sure that `execution_timeout` works on them even while deferred?
   
   Thanks @andrewgodwin . You are right that this PR only really affects `reschedule` mode sensors. It only changes the behaviour of `timeout` and the handling of the corresponding `AirflowSensorTimeout`. I don't think the change applies to Deferrable Operators. The behaviour of `execution_timeout` and the corresponding `AirflowTaskTimeout` is unchanged in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org