You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/20 05:17:41 UTC
Review Request 38532: Add error message when cgroup don't support
memory.pressure_level.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Michael Park.
Bugs: MESOS-3473
https://issues.apache.org/jira/browse/MESOS-3473
Repository: mesos
Description
-------
Add error message when cgroup don't support memory.pressure_level.
Diffs
-----
src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
Diff: https://reviews.apache.org/r/38532/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 38532: Add error message when cgroup don't support
memory.pressure_level.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/#review101442
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38532]
All tests passed.
- Mesos ReviewBot
On Oct. 4, 2015, 6:59 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38532/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2015, 6:59 a.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
>
>
> Bugs: MESOS-3473
> https://issues.apache.org/jira/browse/MESOS-3473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add error message when cgroup don't support memory.pressure_level.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
>
> Diff: https://reviews.apache.org/r/38532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38532: Add error message when cgroup don't support
memory.pressure_level.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/
-----------------------------------------------------------
(Updated Oct. 4, 2015, 6:59 a.m.)
Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
Changes
-------
Update according @gyliu reviews.
Bugs: MESOS-3473
https://issues.apache.org/jira/browse/MESOS-3473
Repository: mesos
Description
-------
Add error message when cgroup don't support memory.pressure_level.
Diffs (updated)
-----
src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
Diff: https://reviews.apache.org/r/38532/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 38532: Add error message when cgroup don't support
memory.pressure_level.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/#review101408
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38532]
All tests passed.
- Mesos ReviewBot
On Oct. 3, 2015, 4 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38532/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 4 p.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
>
>
> Bugs: MESOS-3473
> https://issues.apache.org/jira/browse/MESOS-3473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add error message when cgroup don't support memory.pressure_level.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
>
> Diff: https://reviews.apache.org/r/38532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38532: Add error message when cgroup don't support
memory.pressure_level.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/#review101435
-----------------------------------------------------------
src/tests/containerizer/cgroups_tests.cpp (line 1054)
<https://reviews.apache.org/r/38532/#comment158827>
Does the blank space is needed?
- Guangya Liu
On 十月 3, 2015, 4 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38532/
> -----------------------------------------------------------
>
> (Updated 十月 3, 2015, 4 p.m.)
>
>
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
>
>
> Bugs: MESOS-3473
> https://issues.apache.org/jira/browse/MESOS-3473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add error message when cgroup don't support memory.pressure_level.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
>
> Diff: https://reviews.apache.org/r/38532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 38532: Add error message when cgroup don't support
memory.pressure_level.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/
-----------------------------------------------------------
(Updated Oct. 3, 2015, 4 p.m.)
Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.
Changes
-------
Rebase
Bugs: MESOS-3473
https://issues.apache.org/jira/browse/MESOS-3473
Repository: mesos
Description
-------
Add error message when cgroup don't support memory.pressure_level.
Diffs (updated)
-----
src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
Diff: https://reviews.apache.org/r/38532/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 38532: Add error message when cgroup don't support
memory.pressure_level.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38532/#review99697
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38532]
All tests passed.
- Mesos ReviewBot
On Sept. 20, 2015, 3:17 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38532/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2015, 3:17 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Michael Park.
>
>
> Bugs: MESOS-3473
> https://issues.apache.org/jira/browse/MESOS-3473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add error message when cgroup don't support memory.pressure_level.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
>
> Diff: https://reviews.apache.org/r/38532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>