You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2024/12/19 20:56:49 UTC
[PR] Ensure UI config is fetched before other queries [airflow]
bbovenzi opened a new pull request, #45095:
URL: https://github.com/apache/airflow/pull/45095
Alternative to https://github.com/apache/airflow/pull/44989
Ensure that we have the UI config before any other request is made to the backend.
Ultimately, we should include this as part of the authentication flow.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure UI config is fetched before other queries [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #45095:
URL: https://github.com/apache/airflow/pull/45095#issuecomment-2576057550
> Member
Very weird. Do you want to open those changes as PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure UI config is fetched before other queries [airflow]
Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on PR #45095:
URL: https://github.com/apache/airflow/pull/45095#issuecomment-2561957593
Below seems to fix this issue. I don't see any changes to table state in the fix. Somewhere along the line the search params and table state seem to get out of sync.
```patch
gd src/pages/DagsList/DagsFilters.tsx | cat
diff --git a/airflow/ui/src/pages/DagsList/DagsFilters.tsx b/airflow/ui/src/pages/DagsList/DagsFilters.tsx
index 94cca4d5ee..2c766af8e4 100644
--- a/airflow/ui/src/pages/DagsList/DagsFilters.tsx
+++ b/airflow/ui/src/pages/DagsList/DagsFilters.tsx
@@ -86,11 +86,11 @@ export const DagsFilters = () => {
} else {
searchParams.set(PAUSED_PARAM, val);
}
- setSearchParams(searchParams);
setTableURLState({
pagination: { ...pagination, pageIndex: 0 },
sorting,
});
+ setSearchParams(searchParams);
},
[pagination, searchParams, setSearchParams, setTableURLState, sorting],
);
@@ -103,11 +103,11 @@ export const DagsFilters = () => {
} else {
searchParams.set(LAST_DAG_RUN_STATE_PARAM, value);
}
- setSearchParams(searchParams);
setTableURLState({
pagination: { ...pagination, pageIndex: 0 },
sorting,
});
+ setSearchParams(searchParams);
},
[pagination, searchParams, setSearchParams, setTableURLState, sorting],
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure UI config is fetched before other queries [airflow]
Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on PR #45095:
URL: https://github.com/apache/airflow/pull/45095#issuecomment-2561349881
For some reason the dags page filter buttons by state like failed, running etc. are not working and the url is not updated with the selected state value for `last_dag_run_state`. But selecting the filter from dashboard button applies the query parameter `last_dag_run_state` and it's working fine. I bisected to this commit using below command
Not working
(myenv) ➜ ui git:(main) ✗ git checkout 5e0aeef897 src/
Updated 0 paths from e685b10ac1
Working
(myenv) ➜ ui git:(main) ✗ git checkout 5e0aeef897~1 src/
Updated 3 paths from 222dbe1da5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure UI config is fetched before other queries [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #45095:
URL: https://github.com/apache/airflow/pull/45095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org