You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2023/05/22 16:51:08 UTC
[GitHub] [arrow-adbc] WillAyd opened a new pull request, #696: refactor(c): Use ArrowArrayViewListChildOffset from nanoarrow
WillAyd opened a new pull request, #696:
URL: https://github.com/apache/arrow-adbc/pull/696
Related to https://github.com/apache/arrow-adbc/pull/679#discussion_r1195786712 this pulls down the nanoarrow change https://github.com/apache/arrow-nanoarrow/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #696: refactor(c): Use ArrowArrayViewListChildOffset from nanoarrow
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #696:
URL: https://github.com/apache/arrow-adbc/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] WillAyd commented on pull request #696: refactor(c): Use ArrowArrayViewListChildOffset from nanoarrow
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #696:
URL: https://github.com/apache/arrow-adbc/pull/696#issuecomment-1557595452
Yep thanks for that - oversight on my end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #696: refactor(c): Use ArrowArrayViewListChildOffset from nanoarrow
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #696:
URL: https://github.com/apache/arrow-adbc/pull/696#discussion_r1200810075
##########
c/validation/adbc_validation_util.cc:
##########
@@ -64,20 +64,6 @@ std::string ToString(struct ArrowArrayStream* stream) {
return "";
}
-int64_t ArrowArrayViewGetOffsetUnsafe(struct ArrowArrayView* array_view, int64_t i) {
Review Comment:
Should also be removed from adbc_validation_util.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org