[GitHub] [kyuubi] cfmcgrady commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster

["cfmcgrady (via GitHub)" <gi...@apache.org>]

cfmcgrady commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1099992179


##########
.github/workflows/master.yml:
##########
@@ -347,15 +349,16 @@ jobs:
           file: build/Dockerfile
           load: true
           tags: apache/kyuubi:latest
-      # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
       - name: Setup Minikube
-        uses: manusa/actions-setup-minikube@v2.7.2
-        with:
-          minikube version: 'v1.28.0'
-          kubernetes version: 'v1.25.4'
-          github token: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          # https://minikube.sigs.k8s.io/docs/start/
+          curl -LO https://github.com/kubernetes/minikube/releases/download/${MINIKUBE_VERSION}/minikube-linux-amd64
+          sudo install minikube-linux-amd64 /usr/local/bin/minikube
+          minikube start --cpus 2 --memory 4096 --kubernetes-version=${KUBERNETES_VERSION} --force

Review Comment:
   add a comment to explain why we are doing this resource limit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org