You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/04 08:24:23 UTC

[GitHub] [skywalking-rocketbot-ui] alonelaval opened a new pull request #322: add Flask logo/icon

alonelaval opened a new pull request #322:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/322


   [https://github.com/apache/skywalking-python/pull/31](url)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] alonelaval commented on pull request #322: add Flask logo/icon

Posted by GitBox <gi...@apache.org>.
alonelaval commented on pull request #322:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/322#issuecomment-653883921


   > @alonelaval the last step is adding a component definition in the main repo https://github.com/apache/skywalking/blob/31f42343f6f38ca4838a02866be3bdde7fc3d12a/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L395-L397
   
   ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] kezhenxu94 merged pull request #322: add Flask logo/icon

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #322:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/322


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] alonelaval commented on pull request #322: add Flask logo/icon

Posted by GitBox <gi...@apache.org>.
alonelaval commented on pull request #322:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/322#issuecomment-653769527


   > The icon is too large, please use the small one.
   
   ok


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #322: add Flask logo/icon

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #322:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/322#issuecomment-653843984


   @alonelaval the last step is adding a component definition in the main repo https://github.com/apache/skywalking/blob/31f42343f6f38ca4838a02866be3bdde7fc3d12a/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L395-L397


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #322: add Flask logo/icon

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #322:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/322#issuecomment-653741458


   The icon is too large, please use the small one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org