You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kr...@apache.org on 2013/08/25 15:53:57 UTC
svn commit: r1517290 - in /maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd: AbstractPmdViolationCheckMojo.java CpdViolationCheckMojo.java PmdViolationCheckMojo.java

Author: krosenvold
Date: Sun Aug 25 13:53:56 2013
New Revision: 1517290

URL: http://svn.apache.org/r1517290
Log:
OCD green sidebar code cleanup

Modified:
    maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java
    maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java
    maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java

Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java?rev=1517290&r1=1517289&r2=1517290&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java Sun Aug 25 13:53:56 2013
@@ -251,7 +251,7 @@ public abstract class AbstractPmdViolati
         {
             if ( failureCount > 0 )
             {
-                message.append( "You have " + failureCount + " " + key + ( failureCount > 1 ? "s" : "" ) );
+                message.append("You have ").append(failureCount).append(" ").append(key).append(failureCount > 1 ? "s" : "");
             }
 
             if ( warningCount > 0 )
@@ -264,7 +264,7 @@ public abstract class AbstractPmdViolati
                 {
                     message.append( "You have " );
                 }
-                message.append( warningCount + " warning" + ( warningCount > 1 ? "s" : "" ) );
+                message.append(warningCount).append(" warning").append(warningCount > 1 ? "s" : "");
             }
 
             message.append( ". For more details see:" ).append( outputFile.getAbsolutePath() );

Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java?rev=1517290&r1=1517289&r2=1517290&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java Sun Aug 25 13:53:56 2013
@@ -90,7 +90,7 @@ public class CpdViolationCheckMojo
         int lines = item.getLines();
 
         StringBuilder buff = new StringBuilder( 100 );
-        buff.append( "CPD " + severity + ": Found " );
+        buff.append("CPD ").append(severity).append(": Found ");
         buff.append( lines ).append( " lines of duplicated code at locations:" );
         this.getLog().info( buff.toString() );
 
@@ -170,7 +170,7 @@ public class CpdViolationCheckMojo
         try
         {
             reader = new LineNumberReader( new FileReader( excludeFromFailureFile ) );
-            String line = null;
+            String line;
             while ( ( line = reader.readLine() ) != null )
             {
                 exclusionList.add( createSetFromExclusionLine( line ) );

Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java?rev=1517290&r1=1517289&r2=1517290&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java Sun Aug 25 13:53:56 2013
@@ -154,7 +154,7 @@ public class PmdViolationCheckMojo
     {
 
         StringBuilder buff = new StringBuilder( 100 );
-        buff.append( "PMD " + severity + ": " );
+        buff.append("PMD ").append(severity).append(": ");
         if ( item.getViolationClass() != null )
         {
             if ( item.getViolationPackage() != null )