You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "pseudo-nymous (via GitHub)" <gi...@apache.org> on 2025/05/18 00:20:22 UTC
[PR] Fix for add char and token filters in Luke Analysis tab [lucene]
pseudo-nymous opened a new pull request, #14682:
URL: https://github.com/apache/lucene/pull/14682
### Description
Adds a fix for Luke Analysis tab where user weren't able to add char or token filters.
#### Root Cause:
We have a util method which returns JList's model underlying data, here list of strings representing char filters/token filters. Earlier, the method returned a mutable list which allowed adding new entries to filters. But due to a previous refactoring from `.collect(Collectors.toList()) to .toList()` it returns an immutable list, introduced in https://github.com/apache/lucene/pull/12978.
#### Fix
Revert from `.toList() to .collect(Collectors.toList())` for **ListUtils** class which is only used in CustomAnalyzerPanelProvider class.
Tested locally
Closes https://github.com/apache/lucene/issues/14649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #14682:
URL: https://github.com/apache/lucene/pull/14682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14682:
URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888656024
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14682:
URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888681850
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #14682:
URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888960145
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #14682:
URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888877887
This is a bug - thank you. Could you also add a CHANGES.txt entry under 10.3.0? I'll merge and backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
Posted by "pseudo-nymous (via GitHub)" <gi...@apache.org>.
pseudo-nymous commented on PR #14682:
URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888961089
Happy to contribute!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org