You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "James Medel (Jira)" <ji...@apache.org> on 2020/11/16 05:55:00 UTC

[jira] [Commented] (MINIFICPP-1233) Create Regression Tests for H2O Py Processors

    [ https://issues.apache.org/jira/browse/MINIFICPP-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232549#comment-17232549 ] 

James Medel commented on MINIFICPP-1233:
----------------------------------------

[~oceanfish81] [~szaszm]  [~phrocker] I have written a new C++ test program that is meant to test the h2o python processors. I also updated the CMakeLists.txt file with the new .cpp file, which I am calling "ExecuteH2oPythonProcessorTests.cpp". I also created an "ExecutePythonProcessorTestBase.hpp" from the original .cpp version, so I can include that file in my h2o test cpp file. Next I need to test this new test program and verify the tests pass. There are two tests since there are two h2o processors that I am testing. The first one tests ConvertDsToCsv.py processor's ability to convert a Data source format, in our case JSON to Csv. The second one tests ExecuteH2oMojoScoring.py processor's ability to perform a prediction. I plan to finish testing my program this upcoming week into the weekend.

> Create Regression Tests for H2O Py Processors
> ---------------------------------------------
>
>                 Key: MINIFICPP-1233
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1233
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: James Medel
>            Assignee: James Medel
>            Priority: Blocker
>             Fix For: 0.8.0
>
>         Attachments: CMakeLists.txt
>
>
> Per https://issues.apache.org/jira/browse/MINIFICPP-1214
> We should resolve Marc's and Szasz's concerns about whether [https://github.com/apache/nifi-minifi-cpp/pull/784] breaks these two new processors by having regression tests. We will explore and plan to use pytest-mock ([https://github.com/pytest-dev/pytest-mock]) testing framework to implement the regression tests for the new processors. Therefore, these new processors would be easier to merge.
>  
> regression test concerns



--
This message was sent by Atlassian Jira
(v8.3.4#803005)