You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "JiajunBernoulli (via GitHub)" <gi...@apache.org> on 2023/04/29 08:32:10 UTC

[GitHub] [calcite] JiajunBernoulli commented on pull request #3161: [CALCITE-5657] Add ARRAY_DISTINCT function (enabled in Spark library).

JiajunBernoulli commented on PR #3161:
URL: https://github.com/apache/calcite/pull/3161#issuecomment-1528717808

   @liuyongvs  Do you know why the unit test cannot check result?
   ```
   f.checkScalar("array_distinct(array[1, 2, 2, 1])", "[1]",
       "INTEGER NOT NULL ARRAY NOT NULL");
   ```
   It also success,  but I expect it fail.
   
   [AbstractSqlTester#check](https://github.com/apache/calcite/blob/3326475c766267d521330006cc80730c4e456191/testkit/src/main/java/org/apache/calcite/sql/test/AbstractSqlTester.java#L225) not use resultChecker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org