You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/09 06:34:30 UTC
[GitHub] [hudi] xiarixiaoyao opened a new pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
xiarixiaoyao opened a new pull request #4265:
URL: https://github.com/apache/hudi/pull/4265
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on a change in pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#discussion_r765656666
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -146,12 +153,16 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
override def next(): InternalRow = {
recordToLoad
}
+
+ override def close(): Unit = {
+ if (logScanner != null) logScanner.close()
Review comment:
yes, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989730101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
}, {
"hash" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"triggerType" : "PUSH"
}, {
"hash" : "5f52b5c034373c037c2457e4b12cd75a758694e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f52b5c034373c037c2457e4b12cd75a758694e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
* 2f04666ca6daa8f122133eeaac8c95bcaabdc9c0 UNKNOWN
* 5f52b5c034373c037c2457e4b12cd75a758694e6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989623322
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989707950
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989712724
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989590875
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989559491
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on a change in pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#discussion_r765656862
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -18,6 +18,8 @@
package org.apache.hudi
+import java.io.Closeable
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989592033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989592033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989623322
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989707950
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989705691
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989712724
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989730101
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
}, {
"hash" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"triggerType" : "PUSH"
}, {
"hash" : "5f52b5c034373c037c2457e4b12cd75a758694e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f52b5c034373c037c2457e4b12cd75a758694e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
* 2f04666ca6daa8f122133eeaac8c95bcaabdc9c0 UNKNOWN
* 5f52b5c034373c037c2457e4b12cd75a758694e6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989558237
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989705691
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119)
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989559491
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989586395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989723539
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
}, {
"hash" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
* 2f04666ca6daa8f122133eeaac8c95bcaabdc9c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989586395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989558237
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31c0fd46f52922816e1e023bd9b7c9873ae31fb6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on a change in pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#discussion_r765612550
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -84,6 +86,10 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
s"spark partition Index: ${mergeOnReadPartition.index}" +
s"merge type: ${mergeOnReadPartition.split.mergeType}")
}
+ if (iter.isInstanceOf[Closeable]) {
+ Option(TaskContext.get()).foreach(_.addTaskCompletionListener[Unit](_ => iter.asInstanceOf[Closeable].close()))
Review comment:
would you add some comments about this? not quite sure how this work
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -18,6 +18,8 @@
package org.apache.hudi
+import java.io.Closeable
Review comment:
move to above scala import?
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -146,12 +153,16 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
override def next(): InternalRow = {
recordToLoad
}
+
+ override def close(): Unit = {
+ if (logScanner != null) logScanner.close()
Review comment:
how about add `logScanner = null` after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989723539
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
}, {
"hash" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
* 2f04666ca6daa8f122133eeaac8c95bcaabdc9c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on a change in pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#discussion_r765656401
##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieMergeOnReadRDD.scala
##########
@@ -84,6 +86,10 @@ class HoodieMergeOnReadRDD(@transient sc: SparkContext,
s"spark partition Index: ${mergeOnReadPartition.index}" +
s"merge type: ${mergeOnReadPartition.split.mergeType}")
}
+ if (iter.isInstanceOf[Closeable]) {
+ Option(TaskContext.get()).foreach(_.addTaskCompletionListener[Unit](_ => iter.asInstanceOf[Closeable].close()))
Review comment:
yes，added some comments。
we can find the example in spark， https://github.com/apache/spark/blob/c51f6449d38d30d0bff22df895dca515898a520b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala#L335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989627567
@garyli1019 could you pls help me review this pr, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4265:
URL: https://github.com/apache/hudi/pull/4265#issuecomment-989755066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4116",
"triggerID" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"triggerType" : "PUSH"
}, {
"hash" : "31c0fd46f52922816e1e023bd9b7c9873ae31fb6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4119",
"triggerID" : "989590875",
"triggerType" : "MANUAL"
}, {
"hash" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124",
"triggerID" : "c63dd63a9d3b137fac84a88c6c9256ba6b947d79",
"triggerType" : "PUSH"
}, {
"hash" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f04666ca6daa8f122133eeaac8c95bcaabdc9c0",
"triggerType" : "PUSH"
}, {
"hash" : "5f52b5c034373c037c2457e4b12cd75a758694e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4127",
"triggerID" : "5f52b5c034373c037c2457e4b12cd75a758694e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c63dd63a9d3b137fac84a88c6c9256ba6b947d79 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4124)
* 2f04666ca6daa8f122133eeaac8c95bcaabdc9c0 UNKNOWN
* 5f52b5c034373c037c2457e4b12cd75a758694e6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4127)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 merged pull request #4265: [HUDI-2966] Add TaskCompletionListener for HoodieMergeOnReadRDD to close logScaner when the query finished.
Posted by GitBox <gi...@apache.org>.
garyli1019 merged pull request #4265:
URL: https://github.com/apache/hudi/pull/4265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org