[GitHub] [flink] masteryhx commented on a diff in pull request #20346: [FLINK-28647] Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

[GitBox <gi...@apache.org>]

masteryhx commented on code in PR #20346:
URL: https://github.com/apache/flink/pull/20346#discussion_r932898907


##########
docs/content/docs/ops/state/savepoints.md:
##########
@@ -255,10 +255,8 @@ of the old job will not be deleted by Flink
 
 2. [Native](#savepoint-format) format supports incremental RocksDB savepoints. For those savepoints Flink puts all
 SST files inside the savepoints directory. This means such savepoints are self-contained and relocatable.
-However, when restored in CLAIM mode, subsequent checkpoints might reuse some SST files, which
-in turn might block deleting the savepoints directory at the time the savepoint is subsumed. Later
-on Flink will delete the reused shared SST files, but it won't retry deleting the savepoints directory.
-Therefore, it is possible Flink leaves an empty savepoints directory if it was restored in CLAIM mode.    
+Please note that, when restored in CLAIM mode, subsequent checkpoints might reuse some SST files, which
+might delay the deletion the savepoints directory.

Review Comment:
   IIUC, It works as you modified just after [FLINK-25872](https://issues.apache.org/jira/browse/FLINK-25872), right ?
   Do we have some validations about it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org