You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/26 07:11:27 UTC
[GitHub] [dubbo-go] Mulavar opened a new pull request, #1999: [#1998]fix a bug where filter was not currently working properly and …
Mulavar opened a new pull request, #1999:
URL: https://github.com/apache/dubbo-go/pull/1999
…fix some spelling mistake
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
fix a bug where filter was not currently working properly and fix some spelling mistake
**Which issue(s) this PR fixes**:
Fixes #1988
**You should pay attention to items below to ensure your pr passes our ci test**
We do not merge pr with ci tests failed
- [ ] All ut passed (run 'go test ./...' in project root)
- [ ] After go-fmt ed , run 'go fmt project' using goland.
- [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
- [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above)
- [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
- [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1999: [#1998]fix a bug where filter was not currently working properly in triple protocol
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #1999:
URL: https://github.com/apache/dubbo-go/pull/1999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on pull request #1999: [#1998]fix a bug where filter was not currently working properly in triple protocol
Posted by GitBox <gi...@apache.org>.
Mulavar commented on PR #1999:
URL: https://github.com/apache/dubbo-go/pull/1999#issuecomment-1197819880
I've changed the base branch that this pr should be merged into and re-open the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei closed pull request #1999: [#1998]fix a bug where filter was not currently working properly and …
Posted by GitBox <gi...@apache.org>.
justxuewei closed pull request #1999: [#1998]fix a bug where filter was not currently working properly and …
URL: https://github.com/apache/dubbo-go/pull/1999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1999: [#1998]fix a bug where filter was not currently working properly and …
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1999:
URL: https://github.com/apache/dubbo-go/pull/1999#issuecomment-1195114346
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1999?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1999](https://codecov.io/gh/apache/dubbo-go/pull/1999?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9eb385) into [master](https://codecov.io/gh/apache/dubbo-go/commit/de6fcfbccd909aa75edb23025687eb6271110cba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de6fcfb) will **increase** coverage by `0.07%`.
> The diff coverage is `49.09%`.
```diff
@@ Coverage Diff @@
## master #1999 +/- ##
==========================================
+ Coverage 44.32% 44.40% +0.07%
==========================================
Files 283 283
Lines 17067 17067
==========================================
+ Hits 7565 7578 +13
+ Misses 8696 8687 -9
+ Partials 806 802 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1999?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `27.83% <0.00%> (ø)` | |
| [protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `0.00% <0.00%> (ø)` | |
| [protocol/rest/rest\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2V4cG9ydGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `53.04% <50.00%> (ø)` | |
| [filter/token/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rva2VuL2ZpbHRlci5nbw==) | `53.12% <58.82%> (-6.88%)` | :arrow_down: |
| [protocol/dubbo3/dubbo3\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19leHBvcnRlci5nbw==) | `83.33% <66.66%> (ø)` | |
| [protocol/dubbo3/dubbo3\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19pbnZva2VyLmdv) | `55.65% <66.66%> (ø)` | |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `72.10% <75.00%> (ø)` | |
| [protocol/dubbo/dubbo\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fZXhwb3J0ZXIuZ28=) | `100.00% <100.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/1999/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on pull request #1999: [#1998]fix a bug where filter was not currently working properly and …
Posted by GitBox <gi...@apache.org>.
justxuewei commented on PR #1999:
URL: https://github.com/apache/dubbo-go/pull/1999#issuecomment-1196666331
@Mulavar The wrong branch (master) is set, please submit a new PR and set the correct branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org