You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/17 16:49:12 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1192: Make IO functions return StatusOr

PragmaTwice commented on code in PR #1192:
URL: https://github.com/apache/incubator-kvrocks/pull/1192#discussion_r1051427446


##########
src/common/io_util.cc:
##########
@@ -153,8 +153,7 @@ Status SockConnect(const std::string &host, uint32_t port, int *fd, int conn_tim
         return Status(Status::NotOK, std::string("setsockopt failed: ") + strerror(errno));

Review Comment:
   There are so many code that can be replaced to these new methods, so I think it is not a main point of this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org