You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2014/05/07 22:55:03 UTC
git commit: [SQL] Fix Performance Issue in data type casting
Repository: spark
Updated Branches:
refs/heads/master 3308722ca -> ca4318686
[SQL] Fix Performance Issue in data type casting
Using lazy val object instead of function in the class Cast, which improved the performance nearly by 2X in my local micro-benchmark.
Author: Cheng Hao <ha...@intel.com>
Closes #679 from chenghao-intel/fix_type_casting and squashes the following commits:
71b0902 [Cheng Hao] using lazy val object instead of function for data type casting
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ca431868
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ca431868
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ca431868
Branch: refs/heads/master
Commit: ca43186867f0120c29d1b27cfee0c7ff4a107d84
Parents: 3308722
Author: Cheng Hao <ha...@intel.com>
Authored: Wed May 7 16:54:58 2014 -0400
Committer: Reynold Xin <rx...@apache.org>
Committed: Wed May 7 16:54:58 2014 -0400
----------------------------------------------------------------------
.../scala/org/apache/spark/sql/catalyst/expressions/Cast.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/ca431868/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
index 40d2b42..0b3a4e7 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
@@ -182,7 +182,7 @@ case class Cast(child: Expression, dataType: DataType) extends UnaryExpression {
case x: NumericType => b => x.numeric.asInstanceOf[Numeric[Any]].toFloat(b)
}
- def cast: Any => Any = dataType match {
+ private lazy val cast: Any => Any = dataType match {
case StringType => castToString
case BinaryType => castToBinary
case DecimalType => castToDecimal