You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by TheKingOfGods <gi...@git.apache.org> on 2018/03/09 08:29:18 UTC

[GitHub] incubator-weex pull request #1058: [WEEX-233] [android] More enhanced about ...

Github user TheKingOfGods commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/1058#discussion_r173389264
  
    --- Diff: android/sdk/src/main/java/com/taobao/weex/ui/view/WXWebView.java ---
    @@ -230,7 +295,79 @@ public void onReceivedTitle(WebView view, String title) {
                     }
                 }
     
    +            @Override
    --- End diff --
    
    Yes, `addJavascriptInterface` is better, and it will be used when Android API >= 17 . But there is a [risk](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-6636) before 17. So `prompt`  is used as a downgrade when Android API < 17


---