[GitHub] [incubator-mxnet] barry-jin commented on pull request #20755: [FEATURE] Hardcode build-time branch and commit hash into the library

[GitBox <gi...@apache.org>]

barry-jin commented on pull request #20755:
URL: https://github.com/apache/incubator-mxnet/pull/20755#issuecomment-983246453


   > > @szha it seems that a commit which breakes the [sanity] ci ended up in master. It gives this error on this PR:
   > 
   > Indeed. Not sure how it's happening since the related lines have pylint-disable for them https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/context.py#L19-L20
   > 
   > @barry-jin could you help take a look at the issue and see how the change passed sanity check in the last PR?
   
   I think this issue will be fixed in https://github.com/apache/incubator-mxnet/pull/20763. 
   
   The reason that last pr passed sanity check is sanity_python_prospector is broken at that time and somewhat that pr passed sanity-check: 
   
   ```
   [2021-11-18T18:31:26.574Z] + sanity_python_prospector
   
   [2021-11-18T18:31:26.574Z] + set -e
   
   [2021-11-18T18:31:26.574Z] + set +x
   
   [2021-11-18T18:36:02.980Z] /work/runtime_functions.sh: line 734: [: -ne: unary operator expected
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org