You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/24 12:04:07 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #9718: [Fix-9717] The failure policy of the task flow takes effect

caishunfeng commented on code in PR #9718:
URL: https://github.com/apache/dolphinscheduler/pull/9718#discussion_r857115874


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -456,9 +456,9 @@ private void taskFinished(TaskInstance taskInstance) {
             retryTaskInstance(taskInstance);
         } else if (taskInstance.getState().typeIsFailure()) {
             completeTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
-            if (taskInstance.isConditionsTask()

Review Comment:
   Is it OK if remove the task type check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org