You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/29 23:48:36 UTC

[GitHub] [skywalking] wu-sheng opened a new issue #5591: Metrics about latency of consuming queue

wu-sheng opened a new issue #5591:
URL: https://github.com/apache/skywalking/issues/5591


   Hi @apache/skywalking-committers and @EvanLjp
   
   I created this issue to track the discussion originally started here, https://github.com/apache/skywalking/issues/5584#issuecomment-700793580. The question of #5584  actually is asking for metrics of MQ consuming latency.
   
   Here it is my proposal
   
   The only high-performance way is to propagate the sending time(header injecting timestamp) in the extension header, https://github.com/apache/skywalking/blob/master/docs/en/protocols/Skywalking-Cross-Process-Propagation-Headers-Protocol-v3.md#extension-header-item.
   
   If you are going to implement this, we should consider making it optional, such as
   - `sw8-x` = `0-mq_send_timestamp` or `-mq_send_timestamp`
   - `sw8-x` = `0`
   
   Then, if when the upstream receiving this header, it could be readable by the entry span, the plugin could calculate the latency of this message, add as a new tag as `mq.consum_latency`. Then the OAP could do statistics with a new source.
   
   NOTE, this new field of extension header should be readonly, but wouldn't propagate it because once it is read from the header, it means this message has been consumed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] EvanLjp commented on issue #5591: Metrics about latency of consuming queue

Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #5591:
URL: https://github.com/apache/skywalking/issues/5591#issuecomment-822972322


   Ok, I would finish it in May. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] EvanLjp commented on issue #5591: Metrics about latency of consuming queue

Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #5591:
URL: https://github.com/apache/skywalking/issues/5591#issuecomment-701149395


   This is enough for me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] EvanLjp commented on issue #5591: Metrics about latency of consuming queue

Posted by GitBox <gi...@apache.org>.
EvanLjp commented on issue #5591:
URL: https://github.com/apache/skywalking/issues/5591#issuecomment-922758453


   @wu-sheng I'm worried about whether I can finish this, so I'm going to close this first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] EvanLjp closed issue #5591: Metrics about latency of consuming queue

Posted by GitBox <gi...@apache.org>.
EvanLjp closed issue #5591:
URL: https://github.com/apache/skywalking/issues/5591


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5591: Metrics about latency of consuming queue

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5591:
URL: https://github.com/apache/skywalking/issues/5591#issuecomment-822898833


   @EvanLjp I think we still miss part of this feature. Could you complete this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] EvanLjp edited a comment on issue #5591: Metrics about latency of consuming queue

Posted by GitBox <gi...@apache.org>.
EvanLjp edited a comment on issue #5591:
URL: https://github.com/apache/skywalking/issues/5591#issuecomment-701149395


   This is enough for me.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5591: Metrics about latency of consuming queue

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5591:
URL: https://github.com/apache/skywalking/issues/5591#issuecomment-922756371


   @EvanLjp Do we have expect date to finish this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org