You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2010/01/27 20:37:34 UTC

[jira] Created: (GERONIMO-5051) Taglib discovery does not work

Taglib discovery does not work
------------------------------

                 Key: GERONIMO-5051
                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: osgi, web
            Reporter: Jarek Gawor
            Assignee: Jarek Gawor


There are two problems:
1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5051) Taglib discovery does not work

Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rick McGuire updated GERONIMO-5051:
-----------------------------------

    Issue Type: Sub-task  (was: Bug)
        Parent: GERONIMO-5087

> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805694#action_12805694 ] 

Jarek Gawor commented on GERONIMO-5051:
---------------------------------------

Added a basic test case for tld scanning in revision 903902.


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828462#action_12828462 ] 

Jarek Gawor commented on GERONIMO-5051:
---------------------------------------

I updated Tomcat deployment so that the TLD listeners discovered during deployment are passed to Tomcat. That way Tomcat won't have to scan for these listeners at startup. Committed in revision 905523.


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5051) Taglib discovery does not work

Posted by "Rick McGuire (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901428#action_12901428 ] 

Rick McGuire commented on GERONIMO-5051:
----------------------------------------

Is this ready to be close now?

> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828455#action_12828455 ] 

Jarek Gawor commented on GERONIMO-5051:
---------------------------------------

Updated the test case with a servlet context listener to test that the tld is discovered and its listeners are properly installed.


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831279#action_12831279 ] 

Jarek Gawor commented on GERONIMO-5051:
---------------------------------------

I committed the patch to our Tomcat build - revision 907905.


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMO-5051.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0

Tld discovery should be working now. 


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated GERONIMO-5051:
----------------------------------

    Affects Version/s: 3.0

> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805638#action_12805638 ] 

Jarek Gawor commented on GERONIMO-5051:
---------------------------------------

Fixed both issues in revision 903814. 
The only thing that's not done at deployment or runtime is scanning for container-provided TLDs. We may need to address this in the future.


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reopened GERONIMO-5051:
-----------------------------------


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828455#action_12828455 ] 

Jarek Gawor edited comment on GERONIMO-5051 at 2/2/10 5:44 AM:
---------------------------------------------------------------

Updated the test case with a servlet context listener to test that the tld is discovered and its listeners are properly installed (revision 905522).



      was (Author: gawor@mcs.anl.gov):
    Updated the test case with a servlet context listener to test that the tld is discovered and its listeners are properly installed.

  
> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5051) Taglib discovery does not work

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830299#action_12830299 ] 

Jarek Gawor commented on GERONIMO-5051:
---------------------------------------

The myfaces TLDs are not discovered yet at runtime or deployment time. 

Also, Jasper will need to be modified to read TLDs in other bundles besides the application bundle. I opened https://issues.apache.org/bugzilla/show_bug.cgi?id=48689 to track this issue. I might apply this patch to our Tomcat build.


> Taglib discovery does not work
> ------------------------------
>
>                 Key: GERONIMO-5051
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5051
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>          Components: osgi, web
>    Affects Versions: 3.0
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 3.0
>
>
> There are two problems:
> 1) At runtime the taglibs are not discovered correctly. The current code scans jars based on URLClassLoader which is not present in OSGi environment.
> 2) At deployment time, the deployer assumes a file system and does not work when a bundle is being deployed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.