You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/06/10 18:01:59 UTC

[GitHub] [guacamole-server] aleitner commented on a diff in pull request #383: GUACAMOLE-1622: Added margins to ssh sessions.

aleitner commented on code in PR #383:
URL: https://github.com/apache/guacamole-server/pull/383#discussion_r894779582


##########
src/terminal/terminal/display.h:
##########
@@ -44,6 +44,17 @@
  */
 #define GUAC_TERMINAL_MAX_CHAR_WIDTH 2
 
+/**
+ * The size of margins between the console text and the border in mm.
+ */
+#define GUAC_TERMINAL_MARGINS 2

Review Comment:
   I figured if we wanted to make it adjustable we'd remove the `GUAC_TERMINAL_MARGINS` and add it to the options are something, and it's much easier to think of adjusting in terms of mm rather than 0.0393701 inches



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org