You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/04/19 00:59:25 UTC
Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs
-----
src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f
src/tests/fault_tolerance_tests.cpp 4796149beb10a6c668762f5efecd86520b809c42
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/#review49210
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/20507/#comment86086>
This message is still inaccurate, since there are other reasons the framework could have been marked 'completed'. Either check the timeout before sending this message, or let the framework/scheduler figure out why it was already completed.
- Adam B
On July 21, 2014, 10:35 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20507/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 10:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1219
> https://issues.apache.org/jira/browse/MESOS-1219
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is only a partial fix for MESOS-1219.
>
>
> Diffs
> -----
>
> src/master/master.cpp fb2fd5a0288296370a034d57083cf22992306cea
> src/tests/fault_tolerance_tests.cpp ecf7d5e8aeeabcf1b52104c4b755a322ec808cb6
>
> Diff: https://reviews.apache.org/r/20507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 10:39 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added "depends on".
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs
-----
src/master/master.cpp 56306809096db36bc1884c87957a7b2c76610a93
src/tests/fault_tolerance_tests.cpp 5646cd7d7cfbabd3febcdc52f7d566a2a214f535
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 10:38 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
adam's. NNFR.
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs (updated)
-----
src/master/master.cpp 56306809096db36bc1884c87957a7b2c76610a93
src/tests/fault_tolerance_tests.cpp 5646cd7d7cfbabd3febcdc52f7d566a2a214f535
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/#review48435
-----------------------------------------------------------
Ship it!
These tests are definitely not flaky, right? :)
- Ben Mahler
On July 21, 2014, 5:35 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20507/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 5:35 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1219
> https://issues.apache.org/jira/browse/MESOS-1219
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is only a partial fix for MESOS-1219.
>
>
> Diffs
> -----
>
> src/master/master.cpp fb2fd5a0288296370a034d57083cf22992306cea
> src/tests/fault_tolerance_tests.cpp ecf7d5e8aeeabcf1b52104c4b755a322ec808cb6
>
> Diff: https://reviews.apache.org/r/20507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
(Updated July 21, 2014, 5:35 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added back "depends on" to pacify review bot.
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs
-----
src/master/master.cpp fb2fd5a0288296370a034d57083cf22992306cea
src/tests/fault_tolerance_tests.cpp ecf7d5e8aeeabcf1b52104c4b755a322ec808cb6
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
(Updated July 18, 2014, 6:15 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased. added a new test.
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs (updated)
-----
src/master/master.cpp fb2fd5a0288296370a034d57083cf22992306cea
src/tests/fault_tolerance_tests.cpp ecf7d5e8aeeabcf1b52104c4b755a322ec808cb6
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 16, 2014, 6:35 p.m., Ben Mahler wrote:
> > src/master/master.cpp, line 1359
> > <https://reviews.apache.org/r/20507/diff/3/?file=630340#file630340line1359>
> >
> > Instead of persisting completed frameworks in the registry, I believe we would only persist registered (admitted) frameworks.
> >
> > These frameworks could be re-registered (readmitted) so long as they are in the registry. Or, if the registry is non-strict then we would readmit regardless, akin to what is done for slaves.
> >
> > Could you update the TODO accordingly?
done.
> On July 16, 2014, 6:35 p.m., Ben Mahler wrote:
> > src/master/master.cpp, lines 1360-1361
> > <https://reviews.apache.org/r/20507/diff/3/?file=630340#file630340line1360>
> >
> > As Adam mentioned, this log message seems misleading because it's not necessarily after a failover timeout. Should we just say:
> >
> > "Framework FID attempted to re-register but is already completed"
> >
> > or
> >
> > "Completed framework FID attempted to re-register"
> >
> > This seems like a WARNING from the master's perspective, unless the importance of the framework is why you're making it an ERROR?
done. didn't realize adam meant the log line instead of the comment.
> On July 16, 2014, 6:35 p.m., Ben Mahler wrote:
> > src/tests/fault_tolerance_tests.cpp, lines 906-908
> > <https://reviews.apache.org/r/20507/diff/3/?file=630341#file630341line906>
> >
> > Should we have another test for when the scheduler unregisters itself via stop()?
why not? added.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/#review47923
-----------------------------------------------------------
On July 15, 2014, 12:38 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20507/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 12:38 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1219
> https://issues.apache.org/jira/browse/MESOS-1219
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is only a partial fix for MESOS-1219.
>
>
> Diffs
> -----
>
> src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01
> src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc
>
> Diff: https://reviews.apache.org/r/20507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/#review47923
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/20507/#comment84160>
Instead of persisting completed frameworks in the registry, I believe we would only persist registered (admitted) frameworks.
These frameworks could be re-registered (readmitted) so long as they are in the registry. Or, if the registry is non-strict then we would readmit regardless, akin to what is done for slaves.
Could you update the TODO accordingly?
src/master/master.cpp
<https://reviews.apache.org/r/20507/#comment84162>
As Adam mentioned, this log message seems misleading because it's not necessarily after a failover timeout. Should we just say:
"Framework FID attempted to re-register but is already completed"
or
"Completed framework FID attempted to re-register"
This seems like a WARNING from the master's perspective, unless the importance of the framework is why you're making it an ERROR?
src/tests/fault_tolerance_tests.cpp
<https://reviews.apache.org/r/20507/#comment84164>
Should we have another test for when the scheduler unregisters itself via stop()?
- Ben Mahler
On July 15, 2014, 12:38 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20507/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 12:38 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1219
> https://issues.apache.org/jira/browse/MESOS-1219
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is only a partial fix for MESOS-1219.
>
>
> Diffs
> -----
>
> src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01
> src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc
>
> Diff: https://reviews.apache.org/r/20507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
(Updated July 15, 2014, 12:38 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased. PTAL.
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs (updated)
-----
src/master/master.cpp 86b147fce153fe3a241dbd841e033f2b7ca07b01
src/tests/fault_tolerance_tests.cpp ac65050bec5720b982f53d4dd6797cc3dee285dc
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 23, 2014, 1:06 a.m., Adam B wrote:
> > src/master/master.cpp, lines 1062-1068
> > <https://reviews.apache.org/r/20507/diff/2/?file=563937#file563937line1062>
> >
> > Couldn't this also happen if a (misbehaving) framework completes/fails in any other way, then tries to re-register with the same id? Doesn't have to be a failover timeout.
Thats true. Thats why it says "could" :) I'm open to a better phrasing suggestion though.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/#review41103
-----------------------------------------------------------
On April 22, 2014, 12:20 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20507/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 12:20 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1219
> https://issues.apache.org/jira/browse/MESOS-1219
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is only a partial fix for MESOS-1219.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f
> src/tests/fault_tolerance_tests.cpp 4796149beb10a6c668762f5efecd86520b809c42
>
> Diff: https://reviews.apache.org/r/20507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/#review41103
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/20507/#comment74513>
Couldn't this also happen if a (misbehaving) framework completes/fails in any other way, then tries to re-register with the same id? Doesn't have to be a failover timeout.
- Adam B
On April 21, 2014, 5:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20507/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 5:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1219
> https://issues.apache.org/jira/browse/MESOS-1219
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is only a partial fix for MESOS-1219.
>
>
> Diffs
> -----
>
> src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f
> src/tests/fault_tolerance_tests.cpp 4796149beb10a6c668762f5efecd86520b809c42
>
> Diff: https://reviews.apache.org/r/20507/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
(Updated April 22, 2014, 12:20 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased.
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs (updated)
-----
src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f
src/tests/fault_tolerance_tests.cpp 4796149beb10a6c668762f5efecd86520b809c42
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 20507: Fixed master to reject completed frameworks from
re-registering.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20507/
-----------------------------------------------------------
(Updated April 18, 2014, 10:59 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
depends on.
Bugs: MESOS-1219
https://issues.apache.org/jira/browse/MESOS-1219
Repository: mesos-git
Description
-------
This is only a partial fix for MESOS-1219.
Diffs
-----
src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f
src/tests/fault_tolerance_tests.cpp 4796149beb10a6c668762f5efecd86520b809c42
Diff: https://reviews.apache.org/r/20507/diff/
Testing
-------
make check
Thanks,
Vinod Kone