You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Julius Stroffek (JIRA)" <ji...@apache.org> on 2007/04/16 11:06:15 UTC
[jira] Created: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Global Xid value garbled in syscs_diag.transaction_table.
---------------------------------------------------------
Key: DERBY-2551
URL: https://issues.apache.org/jira/browse/DERBY-2551
Project: Derby
Issue Type: Bug
Affects Versions: 10.3.0.0
Reporter: Julius Stroffek
Assigned To: Julius Stroffek
The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Mike Matrigali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Matrigali updated DERBY-2551:
----------------------------------
Component/s: Services
can this issue be resolved, looks like patch went in.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496081 ]
Knut Anders Hatlen commented on DERBY-2551:
-------------------------------------------
> Using the ClientXid is ok since it only stores the transaction identification and does not contain any client driver related code.
Sounds OK. Perhaps you could add a comment about that in the test.
> Shouldn't we write the tests more sloppy that also a garbage collection would be tested?
Definitely not! :) We have already tried that, and it only made the JUnit tests fail intermittently and randomly. The most common problem is that tearDown() is not allowed to drop a table because some open object depends on the table and hasn't been garbage collected yet. I think there are some tests for memory leaks which implicitly test that garbage collection work.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2551:
--------------------------------------
Attachment: j2me.diff
I forgot one thing in the review. I think the test needs to be disabled under J2ME since it uses XADataSource. The attached patch moves the test into the JDBC 3 section of jdbcapi._Suite and also makes the test itself check the JDBC version in its suite().
Committed revision 538818.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2-try2.diff, d2551-round2-try2.stat, d2551-round2.diff, d2551-round2.stat, d2551.diff, j2me.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495361 ]
Knut Anders Hatlen commented on DERBY-2551:
-------------------------------------------
Hi Julo,
The test looks good, but I have a couple of small comments:
1) The new file (XATransactionTest.java) is tab free with the exception of two lines. It would be great if you could remove the tabs from them as well.
2) The test runs in both embedded and client/server mode, but it always uses ClientXid. Is that OK?
3) If parseXid() used assertNotNull(str) and assertTrue(str.matches(...)) instead of returning null, it would be easier to see the problem if the test fails.
4) Assert.assertTrue(xid.equals(rXid)) could be replaced with Assert.assertEquals(xid, rXid), which provides more information if the test fails.
5) rs, stm and conn aren't closed.
6) Using finally clauses to do clean-up might hide the actual error. If you remove try/finally, it will still do the clean-up when the test runs successfully (which it is supposed to do). If you think it's really needed to have the clean-up in a finally block, I would recommend moving it to the tearDown() method.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495517 ]
Julius Stroffek commented on DERBY-2551:
----------------------------------------
Thanks, Knut!
1, 3, 4, 6)
Thanks, I'll fix theese.
2.) Using the ClientXid is ok since it only stores the transaction identification and does not contain any client driver related code. There is no Xid interface implementation for the embedded driver.
5.) Shouldn't this happen when they got garbage collected? I have consulted the javadoc for Statement.close and Connection.close methods and prior to version 1.6 they should be closed when they get garbage collected. In version 1.6 this sentence disappeared. Shouldn't we write the tests more sloppy that also a garbage collection would be tested?
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julius Stroffek updated DERBY-2551:
-----------------------------------
Derby Info: [Patch Available]
Fix Version/s: 10.3.0.0
10.2.3.0
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.3.0, 10.3.0.0
>
> Attachments: d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490947 ]
Julius Stroffek commented on DERBY-2551:
----------------------------------------
Great! Thanks Knut!
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen resolved DERBY-2551.
---------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Thanks Julo! The latest patch looks good. Committed revision 538770.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2-try2.diff, d2551-round2-try2.stat, d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julius Stroffek updated DERBY-2551:
-----------------------------------
Attachment: d2551.diff
This simple patch dumps the leading zeros in a hex number in case when the corresponding byte of GlobalTRansactionId and BranchQualifier is less then 0x10.
I ran derbyall and suites.All without failures.
Please, review the patch and if you find it to be ok, please apply it to trunk and 10.2 branch also. I will provide an additional patch with a junit test for trunk only.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Attachments: d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-2551:
--------------------------------------
Derby Info: (was: [Patch Available])
Fix Version/s: (was: 10.2.3.0)
10.2.2.1
Committed d2551.diff to trunk with revision 531468 and to 10.2 with revision 531470.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julius Stroffek closed DERBY-2551.
----------------------------------
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2-try2.diff, d2551-round2-try2.stat, d2551-round2.diff, d2551-round2.stat, d2551.diff, j2me.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julius Stroffek updated DERBY-2551:
-----------------------------------
Derby Info: [Patch Available]
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494990 ]
Julius Stroffek commented on DERBY-2551:
----------------------------------------
I would like to provide also a test for the fix for trunk only. I'll do that in following days.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julius Stroffek updated DERBY-2551:
-----------------------------------
Attachment: d2551-round2-try2.stat
d2551-round2-try2.diff
I changed finally to catch with throwing the same exception further even if another one occurs (the new one would be ignored since it is not the one that failed the test). Is it ok to do it that way?I need to call at least rollback on that transaction because the CleanDatabaseSetup will not be able to clean the database because the transaction will keep holding locks.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2-try2.diff, d2551-round2-try2.stat, d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julius Stroffek updated DERBY-2551:
-----------------------------------
Attachment: d2551-round2.stat
d2551-round2.diff
The patch contains the junit test for the trunk.
I ran derbyall and suites.All without failures.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2.diff, d2551-round2.stat, d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Julius Stroffek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496539 ]
Julius Stroffek commented on DERBY-2551:
----------------------------------------
Thanks, Knut. I did not know that something like your j2me patch is necessary.
Thaks again.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Components: Services
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.2.1, 10.3.0.0
>
> Attachments: d2551-round2-try2.diff, d2551-round2-try2.stat, d2551-round2.diff, d2551-round2.stat, d2551.diff, j2me.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2551) Global Xid value garbled in
syscs_diag.transaction_table.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490859 ]
Knut Anders Hatlen commented on DERBY-2551:
-------------------------------------------
The patch looks good to me. I'll run the tests and commit it.
> Global Xid value garbled in syscs_diag.transaction_table.
> ---------------------------------------------------------
>
> Key: DERBY-2551
> URL: https://issues.apache.org/jira/browse/DERBY-2551
> Project: Derby
> Issue Type: Bug
> Affects Versions: 10.3.0.0
> Reporter: Julius Stroffek
> Assigned To: Julius Stroffek
> Fix For: 10.2.3.0, 10.3.0.0
>
> Attachments: d2551.diff
>
>
> The value of global xid is dumped without leading zeros on GlobalTransactionId and BranchQualifier byte arrays. Thus, it is impossible to reconstruct the xid value from the transaction_table.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.