You are viewing a plain text version of this content. The canonical link for it is here.
Posted to submarine-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2019/08/01 14:05:00 UTC
[jira] [Commented] (SUBMARINE-49) Add more test coverage to RunJobParameters

    [ https://issues.apache.org/jira/browse/SUBMARINE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898107#comment-16898107 ] 

Hadoop QA commented on SUBMARINE-49:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color} | {color:green} The patch appears to include 17 new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 42s{color} | {color:green} trunk passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 20s{color} | {color:orange} The patch fails to run checkstyle in hadoop-submarine {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 17s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 16s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m  0s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 16s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 22s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 54s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 21s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 20s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 23s{color} | {color:red} hadoop-submarine-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 14s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 16s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 22s{color} | {color:red} hadoop-submarine in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 22s{color} | {color:red} hadoop-submarine in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 18s{color} | {color:orange} The patch fails to run checkstyle in hadoop-submarine {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 21s{color} | {color:red} hadoop-submarine-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 13s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 13s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m  4s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 16s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 16s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 24s{color} | {color:red} hadoop-submarine-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 17s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 16s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 24s{color} | {color:red} hadoop-submarine-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 16s{color} | {color:red} hadoop-submarine-tony-runtime in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 18s{color} | {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 63m 11s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/Dockerfile |
| JIRA Issue | SUBMARINE-49 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12976437/SUBMARINE-49.008.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 22ff3624212f 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / a7371a7 |
| Default Java | 1.8.0_212 |
| checkstyle | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out//home/jenkins/jenkins-slave/workspace/PreCommit-SUBMARINE-Build/out/maven-branch-checkstyle-hadoop-submarine.txt |
| mvnsite | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| mvnsite | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
| javadoc | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/branch-javadoc-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| javadoc | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/branch-javadoc-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
| findbugs | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/branch-findbugs-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| findbugs | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/branch-findbugs-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
| mvninstall | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-mvninstall-hadoop-submarine_hadoop-submarine-core.txt |
| mvninstall | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-mvninstall-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| mvninstall | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-mvninstall-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
| compile | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-compile-hadoop-submarine.txt |
| javac | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-compile-hadoop-submarine.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out//home/jenkins/jenkins-slave/workspace/PreCommit-SUBMARINE-Build/out/maven-patch-checkstyle-hadoop-submarine.txt |
| mvnsite | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-mvnsite-hadoop-submarine_hadoop-submarine-core.txt |
| mvnsite | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-mvnsite-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| mvnsite | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-mvnsite-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
| javadoc | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-javadoc-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| javadoc | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-javadoc-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
| findbugs | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-findbugs-hadoop-submarine_hadoop-submarine-core.txt |
| findbugs | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-findbugs-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| findbugs | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-findbugs-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
| unit | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-core.txt |
| unit | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-tony-runtime.txt |
| unit | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/testReport/ |
| Max. process+thread count | 308 (vs. ulimit of 5500) |
| modules | C: hadoop-submarine/hadoop-submarine-core hadoop-submarine/hadoop-submarine-tony-runtime hadoop-submarine/hadoop-submarine-yarnservice-runtime U: hadoop-submarine |
| Console output | https://builds.apache.org/job/PreCommit-SUBMARINE-Build/166/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> Add more test coverage to RunJobParameters
> ------------------------------------------
>
>                 Key: SUBMARINE-49
>                 URL: https://issues.apache.org/jira/browse/SUBMARINE-49
>             Project: Hadoop Submarine
>          Issue Type: Sub-task
>            Reporter: Szilard Nemeth
>            Assignee: Adam Antal
>            Priority: Major
>         Attachments: SUBMARINE-49.001.patch, SUBMARINE-49.002.patch, SUBMARINE-49.003.patch, SUBMARINE-49.004.patch, SUBMARINE-49.004.patch, SUBMARINE-49.005.patch, SUBMARINE-49.006.patch, SUBMARINE-49.007.patch, SUBMARINE-49.007.patch, SUBMARINE-49.008.patch, SUBMARINE-49.008.patch, SUBMARINE-49.008.patch, SUBMARINE-49.008.patch
>
>
> There are some good tests in {{org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing}}, but these are not testing all fields set by method {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}. 
> Some more extensive testing is needed in this area.
> As an added bonus, the code {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}} could be cleaned up a bit.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)